Skip to content

Conversation

earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented Oct 3, 2025

Notable changes:

  • Improvements to logging
  • More accurate tracking of promotion failures
  • Use shared allocation for promotions only when the size is above the maximum plab size (not the minimum size)
  • Use census information gathered during mark to size promotion reserves and old generation

With these changes, GenShen is expected to have fewer promotion failures and this is indeed the case. As a result of this, we expect less time to be spent in concurrent marking and update refs for young collections. We may also expect shorter concurrent evacuation phases because GenShen will have fewer densely packed regions stuck in the young generation. With more objects being promoted, we also expect to see longer remembered set scan times. This is generally the case across all benchmarks, but we do also see some counter-intuitive results.

Here we are comparing 20 executions (10 on x86, 10 on aarch64) of the changes in the PR (experiment) against 20 executions of the same benchmarks results from tip. This is a summary of statistically significant changes of more than 5% across all benchmarks:

Concurrent Evacuation: 7 improvements, 3 regressions
• Best improvements: extremem-large-45g (-29.6%), neo4j-analytics (-26.9%)
• Worst regression: xalan (+53.7%)

Concurrent Marking: 15 improvements, 1 regression  
• Best improvements: hyperalloc_a2048_o4096 (-30.1%), crypto.rsa (-27.3%)
• Only regression: serial (+8.9%)

Concurrent Scan Remembered Set: 7 improvements, 2 regressions
• Best improvements: xalan (-49.4%), pmd (-49.0%), crypto.rsa (-41.8%)
• Worst regression: extremem-phased (+52.4%)

Concurrent Update Refs: 5 improvements, 4 regressions
• Best improvements: crypto.rsa (-36.4%), mnemonics (-28.4%)
• Worst regression: xalan (+89.4%)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314599: [GenShen] Couple adaptive tenuring and generation size budgeting (Task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27632/head:pull/27632
$ git checkout pull/27632

Update a local copy of the PR:
$ git checkout pull/27632
$ git pull https://git.openjdk.org/jdk.git pull/27632/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27632

View PR using the GUI difftool:
$ git pr show -t 27632

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27632.diff

Using Webrev

Link to Webrev Comment

Some of the code is left behind to continue collecting the census when adaptive tenuring is disabled.
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2025

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 3, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Oct 3, 2025

⚠️ @earthling-amzn This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk
Copy link

openjdk bot commented Oct 3, 2025

@earthling-amzn The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 3, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 3, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant