-
Notifications
You must be signed in to change notification settings - Fork 6.3k
8314599: [GenShen] Couple adaptive tenuring and generation size budgeting #27632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8314599: [GenShen] Couple adaptive tenuring and generation size budgeting #27632
Conversation
…he first cohort that would be tenured
Some of the code is left behind to continue collecting the census when adaptive tenuring is disabled.
Added tag jdk-26+12 for changeset 02fe095
…o make-evac-tracking-runtime-option
…ed to collection set
…ng excess old regions to young generation)
…ld' into make-evac-tracking-runtime-option
…es when computing excess old regions
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
|
@earthling-amzn The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Notable changes:
With these changes, GenShen is expected to have fewer promotion failures and this is indeed the case. As a result of this, we expect less time to be spent in concurrent marking and update refs for young collections. We may also expect shorter concurrent evacuation phases because GenShen will have fewer densely packed regions stuck in the young generation. With more objects being promoted, we also expect to see longer remembered set scan times. This is generally the case across all benchmarks, but we do also see some counter-intuitive results.
Here we are comparing 20 executions (10 on x86, 10 on aarch64) of the changes in the PR (experiment) against 20 executions of the same benchmarks results from tip. This is a summary of statistically significant changes of more than 5% across all benchmarks:
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27632/head:pull/27632
$ git checkout pull/27632
Update a local copy of the PR:
$ git checkout pull/27632
$ git pull https://git.openjdk.org/jdk.git pull/27632/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27632
View PR using the GUI difftool:
$ git pr show -t 27632
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27632.diff
Using Webrev
Link to Webrev Comment