Skip to content

Conversation

@artur-oracle
Copy link
Member

@artur-oracle artur-oracle commented Oct 23, 2025

We need to address the following inconsistencies in SSLConfiguration#getSSLParameters() call:

  • For the signatureSchemes we return only what's been set by the user, the default values are not being returned like for other SSLParameters.
  • namedGroups return value is not being filtered against algorithm constraints, unlike other SSLParameters.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8366364: Address inconsistencies in SSLParameters object returned by SSLConfiguration#getSSLParameters() call (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27961/head:pull/27961
$ git checkout pull/27961

Update a local copy of the PR:
$ git checkout pull/27961
$ git pull https://git.openjdk.org/jdk.git pull/27961/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27961

View PR using the GUI difftool:
$ git pr show -t 27961

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27961.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2025

👋 Welcome back abarashev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 23, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Oct 23, 2025

@artur-oracle The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-runtime
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 23, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 23, 2025

Webrevs

@AlanBateman
Copy link
Contributor

/label remove core-libs
/label remove hotspot-runtime

@openjdk
Copy link

openjdk bot commented Oct 24, 2025

@AlanBateman
The core-libs label was successfully removed.

@openjdk
Copy link

openjdk bot commented Oct 24, 2025

@AlanBateman
The hotspot-runtime label was successfully removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review security [email protected]

Development

Successfully merging this pull request may close these issues.

3 participants