8370521: GenShen: Various code cleanup related to promotion

[earthling-amzn]

• Use more log tags for finer grained control over debug output.
• Add instrumentation for plab and cset decisions
• Fix typos in comments and minor formatting issues
• Rename some methods and variables for easier reading

There are no behavioral changes here. These changes were hoisted from #27632 to facilitate its review.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8370521: GenShen: Various code cleanup related to promotion (Enhancement - P4)

Reviewers

• Francesco Andreuzzi (@fandreuz - Author)
• Kelvin Nilsen (@kdnilsen - Committer)
• Y. Srinivas Ramakrishna (@ysramakrishna - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27963/head:pull/27963
$ git checkout pull/27963

Update a local copy of the PR:
$ git checkout pull/27963
$ git pull https://git.openjdk.org/jdk.git pull/27963/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27963

View PR using the GUI difftool:
$ git pr show -t 27963

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27963.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370521: GenShen: Various code cleanup related to promotion

Reviewed-by: fandreuzzi, kdnilsen, ysr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 103 new commits pushed to the master branch:

• a926c21: 8370965: Remove SigningPackageFromTwoStepAppImageTest test
• 0e05466: 8370955: Remove test javax/management/remote/mandatory/connection/ConnectionTest.java from ProblemList-Virtual
• a5f3a6f: 8370956: ShortcutHintTest test fails when executed locally on Linux
• ... and 100 more: https://git.openjdk.org/jdk/compare/62f11cd4070f21ad82eebbb5319bdbbf4e13f9cf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@earthling-amzn The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ef5f7547)

[earthling-amzn]

/integrate

[openjdk]

Going to push as commit 6347f10.
Since your change was applied there have been 105 commits pushed to the master branch:

• 3c1010b: 8370646: TestLargeUTF8Length.java needs lots of memory
• dfa04f4: 8370653: Fix race in CompressedClassSpaceSizeInJmapHeap.java
• a926c21: 8370965: Remove SigningPackageFromTwoStepAppImageTest test
• ... and 102 more: https://git.openjdk.org/jdk/compare/62f11cd4070f21ad82eebbb5319bdbbf4e13f9cf...master

Your commit was automatically rebased without conflicts.

[openjdk]

@earthling-amzn Pushed as commit 6347f10.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.