8370568: Refer to Thread.interrupted as "interrupted status" consistently #27972

pavelrappo · 2025-10-24T09:45:38Z

Throughout documentation and source code, the Thread.interrupted flag is referred to as either "interrupted status" or "interrupt status". It might be good to be consistent.

Historically, it seems to have initially been "interrupted status". This is how the flag is called in java.lang.Thread and the "Java Concurrency in Practice" book. ("The Java Programming Language" calls it "interrupted state".) However, over the years "interrupt status" appeared in documentation and source code through networking and NIO classes.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8370568: Refer to Thread.interrupted as "interrupted status" consistently (Bug - P4)

Reviewers

Roger Riggs (@RogerRiggs - Reviewer) Review applies to b3297337
Alan Bateman (@AlanBateman - Reviewer) Review applies to b3297337
Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27972/head:pull/27972
$ git checkout pull/27972

Update a local copy of the PR:
$ git checkout pull/27972
$ git pull https://git.openjdk.org/jdk.git pull/27972/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27972

View PR using the GUI difftool:
$ git pr show -t 27972

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27972.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-10-24T09:46:50Z

👋 Welcome back prappo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-10-24T09:47:51Z

@pavelrappo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370568: Refer to Thread.interrupted as "interrupted status" consistently

Reviewed-by: jpai, rriggs, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-10-24T09:48:53Z

@pavelrappo The following labels will be automatically applied to this pull request:

build
client
compiler
core-libs
hotspot-gc
net
nio
security
serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-10-27T17:51:36Z

Webrevs

RogerRiggs

Looks good.

src/java.base/share/classes/java/util/concurrent/StructuredTaskScope.java

AlanBateman

I skimmed through the replace and it looks okay. There are several places where we should be linking as "interrupted status" will look like a grammatical error with the change. We do that as needed, not this PR.

This is the first update to some of these files in 2025 so you will need to update the copyright header of those files.

src/java.base/share/classes/java/net/DatagramSocket.java

test/jdk/java/lang/Thread/virtual/CustomScheduler.java

Note: any commit hashes below might be outdated due to subsequent history rewriting (e.g. git rebase). + update make/langtools/tools/javacserver/server/CompilerThreadPool.java due to a10f8b4 + update src/java.base/share/classes/java/lang/Object.java due to a10f8b4 + update src/java.base/share/classes/java/net/DatagramSocket.java due to a6a23d6 + update src/java.base/share/classes/java/net/ServerSocket.java due to a6a23d6 + update src/java.base/share/classes/java/nio/channels/DatagramChannel.java due to a10f8b4 + update src/java.base/share/classes/java/nio/channels/FileChannel.java due to a10f8b4 + update src/java.base/share/classes/java/nio/channels/InterruptibleChannel.java due to a10f8b4 + update src/java.base/share/classes/java/nio/channels/ReadableByteChannel.java due to a10f8b4 + update src/java.base/share/classes/java/nio/channels/ScatteringByteChannel.java due to a10f8b4 + update src/java.base/share/classes/java/nio/channels/Selector.java due to a10f8b4 + update src/java.base/share/classes/java/nio/channels/ServerSocketChannel.java due to a10f8b4 + update src/java.base/share/classes/java/nio/channels/SocketChannel.java due to a10f8b4 + update src/java.base/share/classes/sun/nio/ch/Interruptible.java due to a10f8b4 + update src/java.base/share/classes/sun/security/ssl/StatusResponseManager.java due to a10f8b4 + update src/java.desktop/share/classes/java/awt/Robot.java due to a10f8b4 + update src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/DOMParserImpl.java due to a10f8b4 + update src/jdk.sctp/share/classes/com/sun/nio/sctp/SctpChannel.java due to a10f8b4 + update src/jdk.sctp/share/classes/com/sun/nio/sctp/SctpMultiChannel.java due to a10f8b4 + update src/jdk.sctp/share/classes/com/sun/nio/sctp/SctpServerChannel.java due to a10f8b4 + update test/hotspot/jtreg/serviceability/jvmti/vthread/GetThreadState/GetThreadStateTest.java due to a10f8b4 + update test/hotspot/jtreg/vmTestbase/nsk/jvmti/InterruptThread/intrpthrd001/TestDescription.java due to a10f8b4 + update test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/bcinstr/BI04/bi04t002/newclass02/java.base/java/lang/Object.java due to a10f8b4 + update test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/sampling/SP01/sp01t002/TestDescription.java due to a10f8b4 + update test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/sampling/SP01/sp01t003/TestDescription.java due to a10f8b4 + update test/hotspot/jtreg/vmTestbase/nsk/share/gc/AllDiag.java due to a10f8b4 + update test/hotspot/jtreg/vmTestbase/nsk/share/gc/FinDiag.java due to a10f8b4 + update test/hotspot/jtreg/vmTestbase/nsk/share/runner/MemDiag.java due to a10f8b4 + update test/jdk/java/lang/Thread/JoinWithDuration.java due to a10f8b4 + update test/jdk/java/lang/Thread/SleepWithDuration.java due to a10f8b4 + update test/jdk/java/lang/Thread/virtual/CustomScheduler.java due to a6a23d6 + update test/jdk/java/nio/channels/Channels/SocketChannelStreams.java due to a10f8b4 + update test/jdk/java/nio/channels/FileChannel/CloseDuringTransfer.java due to a10f8b4 + update test/jdk/java/nio/channels/FileChannel/ClosedByInterrupt.java due to a10f8b4 + update test/jdk/java/nio/channels/Pipe/PipeInterrupt.java due to a10f8b4 + update test/jdk/java/nio/channels/Selector/LotsOfInterrupts.java due to a10f8b4 + update test/jdk/java/nio/channels/Selector/SelectWithConsumer.java due to a10f8b4 + update test/jdk/java/nio/channels/Selector/WakeupAfterClose.java due to a10f8b4 + update test/jdk/java/nio/channels/SocketChannel/AdaptorStreams.java due to a10f8b4 + update test/jdk/java/nio/file/Files/CallWithInterruptSet.java due to a10f8b4 + update test/jdk/java/nio/file/Files/InterruptCopy.java due to a10f8b4 + update test/jdk/java/util/concurrent/CompletableFuture/LostInterrupt.java due to a10f8b4 + update test/jdk/java/util/concurrent/CompletableFuture/SwallowedInterruptedException.java due to a10f8b4 + update test/jdk/java/util/concurrent/ExecutorService/CloseTest.java due to a10f8b4 + update test/jdk/java/util/concurrent/ExecutorService/InvokeTest.java due to a10f8b4 + update test/jdk/java/util/zip/InterruptibleZip.java due to a10f8b4

RogerRiggs

Nice cleanup.

jaikiran

Hello Pavel, these changes look OK to me.

Over time I think it will be harder to keep track or enforce this in code comments but I think it is easier to enforce for API specification text.

pavelrappo · 2025-10-29T10:23:06Z

Hello Pavel, these changes look OK to me.

Over time I think it will be harder to keep track or enforce this in code comments but I think it is easier to enforce for API specification text.

Moving from "interrupted" to "interrupt" was a slow drift rather than a landslide. I think it's okay to repair it once. Loom is already in and once structured concurrency is in, I don't expect many new occurrences of "interrupt" in the foreseeable future. But you are right, the important bit is the specification, not the code comments.

pavelrappo · 2025-10-29T15:35:28Z

/integrate

openjdk · 2025-10-29T15:36:45Z

Going to push as commit 28f2591.
Since your change was applied there have been 8 commits pushed to the master branch:

eab5644: 8370481: C2 SuperWord: Long/Integer.compareUnsigned return wrong value in SLP
2c07214: 8368249: HttpClient: Translate exceptions thrown by sendAsync
0f34b02: 8365896: Remove unnecessary explicit buffer nul-termination after using os::snprintf
... and 5 more: https://git.openjdk.org/jdk/compare/d8515f084dcd537ccad98f9b15f257baeffae222...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-10-29T15:36:57Z

@pavelrappo Pushed as commit 28f2591.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Initial commit

a10f8b4

openjdk bot added security [email protected] serviceability [email protected] nio [email protected] build [email protected] client [email protected] core-libs [email protected] net [email protected] compiler [email protected] hotspot-gc [email protected] labels Oct 24, 2025

pavelrappo marked this pull request as ready for review October 27, 2025 17:47

openjdk bot added the rfr Pull request is ready for review label Oct 27, 2025

RogerRiggs approved these changes Oct 27, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 27, 2025

AlanBateman reviewed Oct 28, 2025

View reviewed changes

src/java.base/share/classes/java/util/concurrent/StructuredTaskScope.java Outdated Show resolved Hide resolved

AlanBateman approved these changes Oct 28, 2025

View reviewed changes

src/java.base/share/classes/java/net/DatagramSocket.java Outdated Show resolved Hide resolved

src/java.base/share/classes/java/net/DatagramSocket.java Outdated Show resolved Hide resolved

test/jdk/java/lang/Thread/virtual/CustomScheduler.java Outdated Show resolved Hide resolved

pavelrappo added 3 commits October 28, 2025 09:50

Drop to ease upcoming merge from loom repo

4c53832

Reword for clarity as suggested

a6a23d6

openjdk bot removed the ready Pull request is ready to be integrated label Oct 28, 2025

AlanBateman approved these changes Oct 28, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 28, 2025

Merge remote-tracking branch 'jdk/master' into 8370568

b329733

RogerRiggs approved these changes Oct 29, 2025

View reviewed changes

jaikiran approved these changes Oct 29, 2025

View reviewed changes

Merge remote-tracking branch 'jdk/master' into 8370568

c0e453d

Fix one more occurrence

32e4c36

openjdk bot removed the ready Pull request is ready to be integrated label Oct 29, 2025

jaikiran approved these changes Oct 29, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 29, 2025

openjdk bot added the integrated Pull request has been integrated label Oct 29, 2025

openjdk bot closed this Oct 29, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 29, 2025

8370568: Refer to Thread.interrupted as "interrupted status" consistently #27972

8370568: Refer to Thread.interrupted as "interrupted status" consistently #27972

Uh oh!

Conversation

pavelrappo commented Oct 24, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Oct 24, 2025

Uh oh!

openjdk bot commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

RogerRiggs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AlanBateman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RogerRiggs left a comment

Choose a reason for hiding this comment

Uh oh!

jaikiran left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pavelrappo commented Oct 29, 2025

Uh oh!

pavelrappo commented Oct 29, 2025

Uh oh!

openjdk bot commented Oct 29, 2025

Uh oh!

openjdk bot commented Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

pavelrappo commented Oct 24, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Oct 24, 2025 •

edited

Loading

openjdk bot commented Oct 24, 2025 •

edited

Loading

mlbridge bot commented Oct 27, 2025 •

edited

Loading

jaikiran left a comment •

edited

Loading