-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8370438: Offer link time optimization support on library level #27976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MBaesken
wants to merge
11
commits into
openjdk:master
Choose a base branch
from
MBaesken:JDK-8370438
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+37
−14
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d2e1b24
JDK-8370438
MBaesken ab71b58
Suggestions erikj
MBaesken b54cbed
Do not enable LTO for some libs in this PR
MBaesken de4dbf2
Adjust comment
MBaesken 6adc512
Enable lto for BUILD_LIBSPLASHSCREEN, we could add a separate configu…
MBaesken 72ba9ed
Use lto configure flags in hs build
MBaesken 75f8343
Remove lto related comment in flags-cflags.m4
MBaesken e68bc71
Move LTO link flag settings a little up
MBaesken a5e266e
Simplify lto flag assignment for hs in JvmFeatures.gmk
MBaesken bea8d07
Use LINK_TIME_OPTIMIZATION for libjvm build too
MBaesken bc591fd
Add lto to EXTRA_FLAGS, not to OPT
MBaesken File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -226,6 +226,7 @@ ifeq ($(ENABLE_HEADLESS_ONLY), false) | |
| EXCLUDE_FILES := imageioJPEG.c jpegdecoder.c pngtest.c, \ | ||
| EXCLUDES := $(LIBSPLASHSCREEN_EXCLUDES), \ | ||
| OPTIMIZATION := SIZE, \ | ||
| LINK_TIME_OPTIMIZATION := true, \ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You do not need to change it in this patch, it can be done separately per lib. |
||
| CFLAGS := $(LIBSPLASHSCREEN_CFLAGS) \ | ||
| $(GIFLIB_CFLAGS) $(LIBJPEG_CFLAGS) $(PNG_CFLAGS) $(LIBZ_CFLAGS) \ | ||
| $(ICONV_CFLAGS), \ | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice that the compiler args for GCC and Clang are different, but the linker args are the same. Just want to make sure that's intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes they are different, this is 'borrowed' from Hotspot flags, see
jdk/make/hotspot/lib/JvmFeatures.gmk
Line 178 in 9625993
where we supported LTO for some time.