8316274: javax/swing/ButtonGroup/TestButtonGroupFocusTraversal.java fails in Ubuntu 23.10 with Motif LAF

[azvegint]

The test began to fail in Ubuntu 23.10. While investigating, I found and filed two new issues:

• https://bugs.openjdk.org/browse/JDK-8370624 JToggleButton does not display caption if setAction is called
  e.g. setAction vs addActionListener
  vs
• https://bugs.openjdk.org/browse/JDK-8370627 motif look and feel focus traversal order may vary depending on the system version

This test fix changes setAction to addActionListener and it is to avoid problemlisting the test on Linux.

Testing looks good.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8316274: javax/swing/ButtonGroup/TestButtonGroupFocusTraversal.java fails in Ubuntu 23.10 with Motif LAF (Bug - P3)

Reviewers

• Phil Race (@prrace - Reviewer) 🔄 Re-review required (review applies to 9d3495c7)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27979/head:pull/27979
$ git checkout pull/27979

Update a local copy of the PR:
$ git checkout pull/27979
$ git pull https://git.openjdk.org/jdk.git pull/27979/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27979

View PR using the GUI difftool:
$ git pr show -t 27979

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27979.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@azvegint This change is no longer ready for integration - check the PR body for details.

[openjdk]

@azvegint The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (a4680193)
• 00: Full (9d3495c7)

[honkar-jdk]

LGTM apart from minor suggestions (on unchanged lines) :

• blockTillDisplayed Ln#177 and Thread.sleep() Ln#184 can be replaced by robot.delay() for a cleaner code
• Frame title "Test" is generic, can be changed to the test name
• toggleButtonActionPerformed, checkboxActionPerformed volatile vars?

[azvegint]

LGTM apart from minor suggestions (on unchanged lines) :

* blockTillDisplayed Ln#177 and Thread.sleep() Ln#184 can be replaced by robot.delay() for a cleaner code

* Frame title "Test" is generic, can be changed to the test name

* toggleButtonActionPerformed, checkboxActionPerformed volatile vars?

updated