8371923: Update LockFreeStack for Atomic<T> #28329
Open
+53
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this change to the
LockFreeStackutility to allow clients touse
Atomic<T>as the type of the "next" member used in the linked-listrepresentation of the stack. It also continues to allow clients to use the old
(pre-
Atomic<T>) form where the "next" member is volatile. This allowsclients to be updated incrementally after this change, rather than requiring
all clients to be updated in conjunction with the update of this class. Once
all clients have been updated, support for the old form can be removed.
The associated gtests have been updated to use
Atomic<T>, with testing ofthe old form is no longer being done. The non-updated uses provide some
testing, and that's all expected to go away soon. So parameterizing the gtests
for both forms seems like a bunch of work that will just be deleted soon, with
very little benefit.
Testing: mach5 tier1
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28329/head:pull/28329$ git checkout pull/28329Update a local copy of the PR:
$ git checkout pull/28329$ git pull https://git.openjdk.org/jdk.git pull/28329/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28329View PR using the GUI difftool:
$ git pr show -t 28329Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28329.diff
Using Webrev
Link to Webrev Comment