Skip to content

Conversation

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Dec 10, 2025

  • Add exception type as an additional generic parameter to all Throwing... interfaces
  • Add unit tests
  • Add ExceptionBox.toUnchecked(). It is equivalent to ExceptionBox.rethrowUnchecked(), but doesn't throw
  • Replace ExceptionBox.rethrowUnchecked(...) with ExceptionBox.toUnchecked(...); this increased test coverage of "jdk.jpackage.internal.util.function" package from 86% to 97%
  • Change exception handling in ExceptionBox.toUnchecked() (former ExceptionBox.rethrowUnchecked()):
    • InterruptedException: instead of rethrowing an exception of this type, it calls Thread.currentThread().interrupt() and then rethrows it
  • Add ExceptionBox.unbox() (former TKit.unbox()). It is complementary to ExceptionBox.toUnchecked()
  • Catch Exception instead of Throwable where appropriate to avoid catching Error-s. The idea is not to handle fatal errors
  • Replace vague throws Throwable exception specifications with more specific ones where appropriate

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28731/head:pull/28731
$ git checkout pull/28731

Update a local copy of the PR:
$ git checkout pull/28731
$ git pull https://git.openjdk.org/jdk.git pull/28731/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28731

View PR using the GUI difftool:
$ git pr show -t 28731

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28731.diff

…catch Exception-s instead and let Error-s out.
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 10, 2025

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Dec 10, 2025

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

…ses instead of ExceptionBox.rethrowUnchecked(). This change results in 100% coverage for these classes in the unit tests. Add unit tests. Add ExceptionBox.reachedUnreachable().
…Unchecked()`; remove ExceptionBox.rethrowUnchecked().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant