Skip to content

Conversation

@wkia
Copy link

@wkia wkia commented Dec 10, 2025

Increasing number of iterations in the test, to give it a chance to fill CodeCache enough to reach the required threshold to trigger CodeCache GC on Linux-aarch32.

The time of the test is increased, but it seems still reasonable. (15s --> 35s on my laptop, linux64)

I confirm that this fix makes the test passed on linux-aarch32.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8372860: TestCodeCacheUnloadDuringConcCycle fails on ARM32 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28742/head:pull/28742
$ git checkout pull/28742

Update a local copy of the PR:
$ git checkout pull/28742
$ git pull https://git.openjdk.org/jdk.git pull/28742/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28742

View PR using the GUI difftool:
$ git pr show -t 28742

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28742.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 10, 2025

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 10, 2025

@wkia This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372860: TestCodeCacheUnloadDuringConcCycle fails on ARM32

Reviewed-by: tschatzl, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tschatzl, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Dec 10, 2025

@wkia The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 10, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 10, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 10, 2025
@wkia
Copy link
Author

wkia commented Dec 10, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 10, 2025
@openjdk
Copy link

openjdk bot commented Dec 10, 2025

@wkia
Your change (at version 0af5da0) is now ready to be sponsored by a Committer.

@tschatzl
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 11, 2025

Going to push as commit 6a6ff87.
Since your change was applied there have been 11 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 11, 2025
@openjdk openjdk bot closed this Dec 11, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 11, 2025
@openjdk
Copy link

openjdk bot commented Dec 11, 2025

@tschatzl @wkia Pushed as commit 6a6ff87.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc [email protected] integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants