Skip to content

Conversation

@albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Dec 10, 2025

Trivial renaming two *SpacePool classes:

EdenMutableSpacePool -> PSEdenSpacePool
SurvivorMutableSpacePool -> PSSurvivorSpacePool

Test: tier1


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373421: Parallel: Rename young generation eden and survivor space pool (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28744/head:pull/28744
$ git checkout pull/28744

Update a local copy of the PR:
$ git checkout pull/28744
$ git pull https://git.openjdk.org/jdk.git pull/28744/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28744

View PR using the GUI difftool:
$ git pr show -t 28744

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28744.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 10, 2025

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 10, 2025

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373421: Parallel: Rename young generation eden and survivor space pool

Reviewed-by: tschatzl, jsikstro

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8373421 8373421: Parallel: Rename young generation eden and survivor space pool Dec 10, 2025
@openjdk
Copy link

openjdk bot commented Dec 10, 2025

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 10, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 10, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 10, 2025
Copy link
Member

@jsikstro jsikstro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

A side note, I can see that Serial is the only GC that calls its file "serialMemoryPools.hpp", while all other GCs call it "..MemoryPool.hpp". ZGC has its MemoryPool implementation in zServiceability.hpp.

$ find src/hotspot/share/gc -name "*MemoryPool*.hpp"
src/hotspot/share/gc/epsilon/epsilonMemoryPool.hpp
src/hotspot/share/gc/g1/g1MemoryPool.hpp
src/hotspot/share/gc/parallel/psMemoryPool.hpp
src/hotspot/share/gc/serial/serialMemoryPools.hpp
src/hotspot/share/gc/shenandoah/shenandoahMemoryPool.hpp

@albertnetymk
Copy link
Member Author

Thanks for review.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 11, 2025

Going to push as commit aa986be.
Since your change was applied there have been 9 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 11, 2025
@openjdk openjdk bot closed this Dec 11, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 11, 2025
@openjdk
Copy link

openjdk bot commented Dec 11, 2025

@albertnetymk Pushed as commit aa986be.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the pgc-space-pool-rename branch December 11, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc [email protected] integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants