Skip to content

Conversation

@nizarbenalla
Copy link
Member

@nizarbenalla nizarbenalla commented Dec 10, 2025

Usual symbol file update for a new JDK build.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373443: Update --release 26 symbol information for JDK 26 build 27 (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28753/head:pull/28753
$ git checkout pull/28753

Update a local copy of the PR:
$ git checkout pull/28753
$ git pull https://git.openjdk.org/jdk.git pull/28753/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28753

View PR using the GUI difftool:
$ git pr show -t 28753

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28753.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 10, 2025

👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 10, 2025

@nizarbenalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373443: Update --release 26 symbol information for JDK 26 build 27

Reviewed-by: jlahoda, iris, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Dec 10, 2025

@nizarbenalla The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 10, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 10, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 10, 2025
Copy link
Member

@jddarcy jddarcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible.

@lahodaj
Copy link
Contributor

lahodaj commented Dec 10, 2025

I am sorry, but some files appear to be missing from the change. Like src/jdk.compiler/share/data/symbols/jdk.incubator.foreign-Q.sym.txt, but a few others as well (sql, jpackage).

@nizarbenalla
Copy link
Member Author

Sorry about that, I had some untracked files in my workspace and didn't notice that the script produced a few new ones.
I've included the missing files now.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Dec 10, 2025
@jddarcy
Copy link
Member

jddarcy commented Dec 11, 2025

I am sorry, but some files appear to be missing from the change. Like src/jdk.compiler/share/data/symbols/jdk.incubator.foreign-Q.sym.txt, but a few others as well (sql, jpackage).

Good catch Jan; thanks.

Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 11, 2025
@nizarbenalla
Copy link
Member Author

Thanks for the reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 11, 2025

Going to push as commit 692edc4.
Since your change was applied there have been 12 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 11, 2025
@openjdk openjdk bot closed this Dec 11, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 11, 2025
@openjdk
Copy link

openjdk bot commented Dec 11, 2025

@nizarbenalla Pushed as commit 692edc4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@nizarbenalla nizarbenalla deleted the symbol-update-jdk-26-b27 branch December 11, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler [email protected] integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants