Skip to content

8373449: Parallel: Obsolete deprecated PSChunkLargeArrays #28754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
albertnetymk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

8373449: Parallel: Obsolete deprecated PSChunkLargeArrays #28754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/hotspot/share/gc/parallel/parallel_globals.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,7 @@
constraint) \
product(bool, UseMaximumCompactionOnSystemGC, true, \
"Use maximum compaction in the Parallel Old garbage collector " \
"for a system GC") \
\
product(bool, PSChunkLargeArrays, true, \
"(Deprecated) Process large arrays in chunks")
"for a system GC")

// end of GC_PARALLEL_FLAGS

Expand Down
4 changes: 1 addition & 3 deletions src/hotspot/share/gc/parallel/psPromotionManager.inline.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,8 +299,7 @@ inline oop PSPromotionManager::copy_unmarked_to_survivor_space(oop o,
// _min_array_size_for_chunking, and most of them will be arrays.
// So, the objArray test would be very infrequent.
if (new_obj_size > _min_array_size_for_chunking &&
klass->is_objArray_klass() &&
PSChunkLargeArrays) {
klass->is_objArray_klass()) {
push_objArray(o, new_obj);
} else {
// we'll just push its contents
Expand Down Expand Up @@ -344,7 +343,6 @@ inline void PSPromotionManager::copy_and_push_safe_barrier(T* p) {
inline void PSPromotionManager::process_popped_location_depth(ScannerTask task,
bool stolen) {
if (task.is_partial_array_state()) {
assert(PSChunkLargeArrays, "invariant");
process_array_chunk(task.to_partial_array_state(), stolen);
} else {
if (task.is_narrow_oop_ptr()) {
Expand Down
2 changes: 1 addition & 1 deletion src/hotspot/share/runtime/arguments.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,6 @@ static SpecialFlag const special_jvm_flags[] = {
#endif
{ "ParallelRefProcEnabled", JDK_Version::jdk(26), JDK_Version::jdk(27), JDK_Version::jdk(28) },
{ "ParallelRefProcBalancingEnabled", JDK_Version::jdk(26), JDK_Version::jdk(27), JDK_Version::jdk(28) },
{ "PSChunkLargeArrays", JDK_Version::jdk(26), JDK_Version::jdk(27), JDK_Version::jdk(28) },
{ "MaxRAM", JDK_Version::jdk(26), JDK_Version::jdk(27), JDK_Version::jdk(28) },
{ "AggressiveHeap", JDK_Version::jdk(26), JDK_Version::jdk(27), JDK_Version::jdk(28) },
{ "NeverActAsServerClassMachine", JDK_Version::jdk(26), JDK_Version::jdk(27), JDK_Version::jdk(28) },
Expand Down Expand Up @@ -580,6 +579,7 @@ static SpecialFlag const special_jvm_flags[] = {
{ "PretenureSizeThreshold", JDK_Version::undefined(), JDK_Version::jdk(26), JDK_Version::jdk(27) },
{ "HeapMaximumCompactionInterval",JDK_Version::undefined(), JDK_Version::jdk(26), JDK_Version::jdk(27) },

{ "PSChunkLargeArrays", JDK_Version::jdk(26), JDK_Version::jdk(27), JDK_Version::jdk(28) },
#ifdef ASSERT
{ "DummyObsoleteTestFlag", JDK_Version::undefined(), JDK_Version::jdk(18), JDK_Version::undefined() },
#endif
Expand Down