8373389: Two jdk/incubator/vector/ tests fails after JDK-8371446

[xuemingshen-oracle]

Test case ByteNNNVectorTests.MULReduceByteNNNVectorTestsMasked (specifically av.reduceLanes(VectorOperators.MUL, vmask)) fails "intermittently" with the newly added test data mask[random] on certain CPUs, likely those using AVX-512. For example, AMD_EPYC_9J14_96-Core is the one consistently fails.

This new mask data was added to BOOLEAN_MASK_GENERATORS as part of the changes for JDK-8371446 #28593

            withToString("mask[random]", (int s) -> {
                return fill_boolean(s,_i -> RAND.nextBoolean());
            })

Although this addition does reveals a potential bug in C2's av.reduceLanes(VectorOperators.MUL, vmask) implementation, it unfortunately introduces nosy, non-deterministic tier3 test failures in the vector API test suite.

This change temporarily remove this data entry from BOOLEAN_MASK_GENERATORS to reduce the the test instability.

This change also includes the regenerated test updates from gen-test.sh to sync the template and the generated test code, addressing the issue reported in JDK-8373390.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8373389: Two jdk/incubator/vector/ tests fails after JDK-8371446 (Bug - P4)

Reviewers

• Paul Sandoz (@PaulSandoz - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28757/head:pull/28757
$ git checkout pull/28757

Update a local copy of the PR:
$ git checkout pull/28757
$ git pull https://git.openjdk.org/jdk.git pull/28757/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28757

View PR using the GUI difftool:
$ git pr show -t 28757

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28757.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sherman! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@xuemingshen-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373389: Two jdk/incubator/vector/ tests fails after JDK-8371446

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 692edc4: 8373443: Update --release 26 symbol information for JDK 26 build 27
• 2a1c676: 8373464: Test JdkManagementCheckSince.java fails after JDK-8369736
• b0bd0c3: 8372759: Test build/AbsPathsInImage.java fails after JDK-8370438
• ... and 10 more: https://git.openjdk.org/jdk/compare/54430a87226096725b13f05326d08629420657ca...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@xuemingshen-oracle To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• net
• nio
• security
• serviceability
• shenandoah

[xuemingshen-oracle]

/label core-libs

[openjdk]

@xuemingshen-oracle
The core-libs label was successfully added.

[mlbridge]

Webrevs

• 00: Full (9b8a2167)

[shipilev]

Although this addition does reveals a potential bug in C2's av.reduceLanes(VectorOperators.MUL, vmask) implementation, it unfortunately introduces nosy, non-deterministic tier3 test failures in the vector API test suite.

Does that mean we should problem-list the tests, instead of changing them?

[PaulSandoz]

Although this addition does reveals a potential bug in C2's av.reduceLanes(VectorOperators.MUL, vmask) implementation, it unfortunately introduces nosy, non-deterministic tier3 test failures in the vector API test suite.

Does that mean we should problem-list the tests, instead of changing them?

Its a trade off, we really want to problem list the problematic data and only on certain platforms, but we can't and so problem listing the test is broader than we would actually like. Further, resolving why the tests are failing for that data on the specific AVX512 platforms may take some time. So in this case i think it best to revert closer to the prior data we used, while retaining the updated test computation.

[PaulSandoz]

I don't see any update to the template file(s), did you forget to include that in the commit?

[PaulSandoz]

I don't see any update to the template file(s), did you forget to include that in the commit?

Answering myself, ah, i see now if i read the details section properly :-)

[xuemingshen-oracle]

/integrate

[openjdk]

Going to push as commit ae85d89.
Since your change was applied there have been 15 commits pushed to the master branch:

• 66d7b0c: 8371657: [macosx] Programmatically selecting/deselecting List item triggers an ItemEvent
• 431dcf8: 8368702: [macosx] Printing text with composite fonts loses font transform
• 692edc4: 8373443: Update --release 26 symbol information for JDK 26 build 27
• ... and 12 more: https://git.openjdk.org/jdk/compare/54430a87226096725b13f05326d08629420657ca...master

Your commit was automatically rebased without conflicts.

[openjdk]

@xuemingshen-oracle Pushed as commit ae85d89.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.