Skip to content

Conversation

@iklam
Copy link
Member

@iklam iklam commented Dec 11, 2025

Please review this small fix and the plan of action for backporting JDK-8369736 to JDK 26.

(JDK-8369736 is under https://openjdk.org/jeps/3#Late-Enhancement-Request-Process)

Background

The "actually introduced version" for HotSpotAOTCacheMXBean is found using the ct.sym file (JdkManagementCheckSince.java uses test/jdk/tools/sincechecker/SinceChecker.java, which doesn't read ct.sym directly, but uses JavacTool with --release N, which in turn loads ct.sym)

$ unzip -l ./images/jdk/lib/ct.sym | grep HotSpotAOTCacheMXBean.sig
      167 2025-12-11 03:16 R/jdk.management/jdk/management/HotSpotAOTCacheMXBean.sig

"R" is JDK 27 ("1" is JDK 1, "A" is JDK 10, "B" is JDK 11, etc ...)

In comparison, VirtualThreadSchedulerMXBean was first introduced in "O" = JDK 24, and its API has not changed since)

$ unzip -l ./images/jdk/lib/ct.sym | grep VirtualThreadSchedulerMXBean.sig
      313 2025-12-11 03:16 OPQR/jdk.management/jdk/management/VirtualThreadSchedulerMXBean.sig

Note that if an API has evolved over time, we may have several .sig files:

$ unzip -l ./images/jdk/lib/ct.sym | grep util/Vector.sig
     3058 2025-12-11 03:16 8/java.base/java/util/Vector.sig
     3182 2025-12-11 03:16 9A/java.base/java/util/Vector.sig
     3272 2025-12-11 03:16 BCDEFGHIJKLMNOPQR/java.base/java/util/Vector.sig

ct.sym is generated from files in src/jdk.compiler/share/data/symbols

$ cd src/jdk.compiler/share/data/symbols
$ grep VirtualThreadSchedulerMXBean *
jdk.management-O.sym.txt:class name jdk/management/VirtualThreadSchedulerMXBean

Because HotSpotAOTCacheMXBean is not listed in any of the .sym.txt files, it's added as version "R" in ct.sym

$ grep HotSpotAOTCacheMXBean * | wc
      0 0 0

Proposed plan of action

  1. In the mainline, update HotSpotAOTCacheMXBean.java to use @since 27 (this PR) to fix the current test failure in the mainline.

  2. When backporting HotSpotAOTCacheMXBean.java to JDK 26 (with approval), it should have @since 26.

  3. After JDK 26 is finalized, update the mainline:

    • Add HotSpotAOTCacheMXBean to jdk.management-Q.sym.txt
    • Update HotSpotAOTCacheMXBean.java to use @since 26.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373464: Test JdkManagementCheckSince.java fails after JDK-8369736 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28760/head:pull/28760
$ git checkout pull/28760

Update a local copy of the PR:
$ git checkout pull/28760
$ git pull https://git.openjdk.org/jdk.git pull/28760/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28760

View PR using the GUI difftool:
$ git pr show -t 28760

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28760.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 11, 2025

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 11, 2025

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373464: Test JdkManagementCheckSince.java fails after JDK-8369736

Reviewed-by: dholmes, shade, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 920a99f: 8370731: Tests in vmTestbase/nsk/monitoring/GarbageCollectorMXBean/CollectionCounters/ failed: OutOfMemoryError

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Dec 11, 2025

@iklam The following labels will be automatically applied to this pull request:

  • jmx
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 11, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 11, 2025

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and trivial. Thanks for fixing.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 11, 2025
Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@iklam
Copy link
Member Author

iklam commented Dec 11, 2025

Thanks @dholmes-ora @shipilev @kevinjwalls for the review
/integrate

@openjdk
Copy link

openjdk bot commented Dec 11, 2025

Going to push as commit 2a1c676.
Since your change was applied there have been 7 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 11, 2025
@openjdk openjdk bot closed this Dec 11, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 11, 2025
@openjdk
Copy link

openjdk bot commented Dec 11, 2025

@iklam Pushed as commit 2a1c676.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants