-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8373464: Test JdkManagementCheckSince.java fails after JDK-8369736 #28760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8373464: Test JdkManagementCheckSince.java fails after JDK-8369736 #28760
Conversation
|
👋 Welcome back iklam! A progress list of the required criteria for merging this PR into |
|
@iklam This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
dholmes-ora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good and trivial. Thanks for fixing.
shipilev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
Thanks @dholmes-ora @shipilev @kevinjwalls for the review |
|
Going to push as commit 2a1c676.
Your commit was automatically rebased without conflicts. |
Please review this small fix and the plan of action for backporting JDK-8369736 to JDK 26.
(JDK-8369736 is under https://openjdk.org/jeps/3#Late-Enhancement-Request-Process)
Background
The "actually introduced version" for
HotSpotAOTCacheMXBeanis found using thect.symfile (JdkManagementCheckSince.java uses test/jdk/tools/sincechecker/SinceChecker.java, which doesn't readct.symdirectly, but usesJavacToolwith--release N, which in turn loadsct.sym)"R" is JDK 27 ("1" is JDK 1, "A" is JDK 10, "B" is JDK 11, etc ...)
In comparison,
VirtualThreadSchedulerMXBeanwas first introduced in "O" = JDK 24, and its API has not changed since)Note that if an API has evolved over time, we may have several
.sigfiles:ct.symis generated from files in src/jdk.compiler/share/data/symbolsBecause
HotSpotAOTCacheMXBeanis not listed in any of the.sym.txtfiles, it's added as version "R" inct.symProposed plan of action
In the mainline, update HotSpotAOTCacheMXBean.java to use
@since 27(this PR) to fix the current test failure in the mainline.When backporting HotSpotAOTCacheMXBean.java to JDK 26 (with approval), it should have
@since 26.After JDK 26 is finalized, update the mainline:
jdk.management-Q.sym.txt@since 26.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28760/head:pull/28760$ git checkout pull/28760Update a local copy of the PR:
$ git checkout pull/28760$ git pull https://git.openjdk.org/jdk.git pull/28760/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28760View PR using the GUI difftool:
$ git pr show -t 28760Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28760.diff
Using Webrev
Link to Webrev Comment