Skip to content

Conversation

@shqking
Copy link
Contributor

@shqking shqking commented Dec 24, 2025

Hi all,

This pull request contains a backport of commit e1d81c09 from the openjdk/jdk repository.

The commit being backported was authored by Hao Sun on 23 Dec 2025 and was reviewed by Markus Grönlund, Jie Fu and Francesco Andreuzzi.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373122: JFR build failure with CDS disabled due to -Werror=unused-function after JDK-8365400 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28976/head:pull/28976
$ git checkout pull/28976

Update a local copy of the PR:
$ git checkout pull/28976
$ git pull https://git.openjdk.org/jdk.git pull/28976/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28976

View PR using the GUI difftool:
$ git pr show -t 28976

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28976.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 24, 2025

👋 Welcome back haosun! A progress list of the required criteria for merging this PR into jdk26 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 24, 2025

@shqking This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373122: JFR build failure with CDS disabled due to -Werror=unused-function after JDK-8365400

Reviewed-by: fandreuzzi, jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the jdk26 branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk26 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport e1d81c0946364a266a006481a8fbbac24c7e6c6a 8373122: JFR build failure with CDS disabled due to -Werror=unused-function after JDK-8365400 Dec 24, 2025
@openjdk
Copy link

openjdk bot commented Dec 24, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required hotspot-jfr [email protected] labels Dec 24, 2025
@openjdk
Copy link

openjdk bot commented Dec 24, 2025

@shqking The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 24, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 24, 2025

Webrevs

@shqking
Copy link
Contributor Author

shqking commented Dec 24, 2025

/label add build

@openjdk
Copy link

openjdk bot commented Dec 24, 2025

@shqking
The build label was successfully added.

@shqking
Copy link
Contributor Author

shqking commented Dec 24, 2025

GHA test linux-x64/build failed. I don't think it's related to this patch. I noticed that this GHA test failed in several other PRs.

@shqking
Copy link
Contributor Author

shqking commented Jan 2, 2026

Hi, I would appreciate it if you could help review this backport patch again. Thanks.

@fandreuz @DamonFool and @mgronlun

@shqking
Copy link
Contributor Author

shqking commented Jan 7, 2026

I would appreciate it if someone could help review this backport patch. Thanks.

Copy link
Member

@DamonFool DamonFool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 7, 2026
@shqking
Copy link
Contributor Author

shqking commented Jan 7, 2026

Thanks a lot for your reviews. @fandreuz @DamonFool

/integrate

@openjdk
Copy link

openjdk bot commented Jan 7, 2026

Going to push as commit 3103fa0.
Since your change was applied there have been 7 commits pushed to the jdk26 branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 7, 2026
@openjdk openjdk bot closed this Jan 7, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 7, 2026
@openjdk
Copy link

openjdk bot commented Jan 7, 2026

@shqking Pushed as commit 3103fa0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shqking shqking deleted the backport-shqking-e1d81c09-jdk26 branch January 7, 2026 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base build [email protected] clean Identical backport; no merge resolution required hotspot-jfr [email protected] integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants