-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8373122: JFR build failure with CDS disabled due to -Werror=unused-function after JDK-8365400 #28976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8373122: JFR build failure with CDS disabled due to -Werror=unused-function after JDK-8365400 #28976
Conversation
|
👋 Welcome back haosun! A progress list of the required criteria for merging this PR into |
|
@shqking This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
/label add build |
|
@shqking |
|
GHA test linux-x64/build failed. I don't think it's related to this patch. I noticed that this GHA test failed in several other PRs. |
|
Hi, I would appreciate it if you could help review this backport patch again. Thanks. |
|
I would appreciate it if someone could help review this backport patch. Thanks. |
DamonFool
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks a lot for your reviews. @fandreuz @DamonFool /integrate |
|
Going to push as commit 3103fa0.
Your commit was automatically rebased without conflicts. |
Hi all,
This pull request contains a backport of commit e1d81c09 from the openjdk/jdk repository.
The commit being backported was authored by Hao Sun on 23 Dec 2025 and was reviewed by Markus Grönlund, Jie Fu and Francesco Andreuzzi.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28976/head:pull/28976$ git checkout pull/28976Update a local copy of the PR:
$ git checkout pull/28976$ git pull https://git.openjdk.org/jdk.git pull/28976/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28976View PR using the GUI difftool:
$ git pr show -t 28976Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28976.diff
Using Webrev
Link to Webrev Comment