Skip to content

Conversation

@rwestrel
Copy link
Contributor

@rwestrel rwestrel commented Jan 5, 2026

Hi all,

This pull request contains a backport of commit 2ba423db from the openjdk/jdk repository.

The commit being backported was authored by Roland Westrelin on 18 Dec 2025 and was reviewed by Roberto Castañeda Lozano, Daniel Lundén and Damon Fenacci.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370200: Crash: assert(outer->outcnt() >= phis + 2 - be_loads && outer->outcnt() <= phis + 2 + stores + 1) failed: only phis (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29041/head:pull/29041
$ git checkout pull/29041

Update a local copy of the PR:
$ git checkout pull/29041
$ git pull https://git.openjdk.org/jdk.git pull/29041/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29041

View PR using the GUI difftool:
$ git pr show -t 29041

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29041.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2026

👋 Welcome back roland! A progress list of the required criteria for merging this PR into jdk26 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 5, 2026

@rwestrel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370200: Crash: assert(outer->outcnt() >= phis + 2 - be_loads && outer->outcnt() <= phis + 2 + stores + 1) failed: only phis

Reviewed-by: chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk26 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk26 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 2ba423db9925355348106fc9fcf84450123d2605 8370200: Crash: assert(outer->outcnt() >= phis + 2 - be_loads && outer->outcnt() <= phis + 2 + stores + 1) failed: only phis Jan 5, 2026
@openjdk
Copy link

openjdk bot commented Jan 5, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required hotspot-compiler [email protected] labels Jan 5, 2026
@openjdk
Copy link

openjdk bot commented Jan 5, 2026

@rwestrel The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 5, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2026

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I will submit some testing for it together with #29042.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 6, 2026
@chhagedorn
Copy link
Member

Testing passed.

@rwestrel
Copy link
Contributor Author

rwestrel commented Jan 7, 2026

@chhagedorn thanks for the review and testing

@rwestrel
Copy link
Contributor Author

rwestrel commented Jan 7, 2026

/integrate

@openjdk
Copy link

openjdk bot commented Jan 7, 2026

Going to push as commit 3213465.
Since your change was applied there have been 5 commits pushed to the jdk26 branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 7, 2026
@openjdk openjdk bot closed this Jan 7, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 7, 2026
@openjdk
Copy link

openjdk bot commented Jan 7, 2026

@rwestrel Pushed as commit 3213465.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required hotspot-compiler [email protected] integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants