-
Notifications
You must be signed in to change notification settings - Fork 252
8303215: Make thread stacks not use huge pages #2208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
@gnu-andrew maybe ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the start of os::large_page_init(), there's an extra blank line after the method signature. Otherwise fine.
Thank you, Paul! |
|
|
|
@tstuefe This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
@tstuefe This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
|
HI, I am facing a bug described in JDK-8312182 and would like to apply the JDK-8312182's fix to jdk11 and jdk8. Could you reopen this PR and issue a Fix Request? Thanks. |
|
Sorry to bother you, but I'd appreciate it if you could check #2208 (comment). Thanks. |
|
@kurashige23, you could also just file new PRs. |
|
@kurashige23 , @phohensee |
Backported for parity with Oracle and as preparation to fix https://bugs.openjdk.org/browse/JDK-8312182.
Backport is unclean, but the difference is minor. I had to adjust hunks in
os::large_page_init()since the surrounding coding changed a lot since JDK 11.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2208/head:pull/2208$ git checkout pull/2208Update a local copy of the PR:
$ git checkout pull/2208$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2208/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2208View PR using the GUI difftool:
$ git pr show -t 2208Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2208.diff
Webrev
Link to Webrev Comment