-
Notifications
You must be signed in to change notification settings - Fork 253
8347911: Limit the length of inflated text chunks #3083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewed-by: phh Backport-of: 6b55ef3
Backport-of: 70c6df6be431fe11c5441986ed04040f9ec3b750
Backport-of: 398a580518b4e7961bdddf733e0a89ff25bc437a
|
👋 Welcome back tpushkin! A progress list of the required criteria for merging this PR into |
|
@TimPushkin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
The CI failure seems unrelated, see #3081 (comment) for a discussion of a similar failure in a dependency. |
|
/approval request Backporting for parity with Oracle. |
|
@TimPushkin |
|
@TimPushkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@TimPushkin The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
Hi @TimPushkin |
|
@TimPushkin Apologies, you are correct. I was looking at the wrong issue. |
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8347911-jdk11
git fetch https://git.openjdk.org/jdk11u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
@TimPushkin Please resolve the conflict here and merge latest master. Thanks! |
Backport-of: 398a580518b4e7961bdddf733e0a89ff25bc437a
|
CI failures are caused by some infrastructure issues, not by the change: the jobs failed to download JTReg |
|
/integrate |
|
@TimPushkin |
|
/sponsor |
|
Going to push as commit 085a7f1. |
|
@alexeybakhtin @TimPushkin Pushed as commit 085a7f1. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of JDK-8347911 from JDK 17, for parity with Oracle 11.0.27.
No conflicts.
Testing: GitHub CI,
jdk_imageiotest group locally (mac/arm64)Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3083/head:pull/3083$ git checkout pull/3083Update a local copy of the PR:
$ git checkout pull/3083$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3083/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3083View PR using the GUI difftool:
$ git pr show -t 3083Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3083.diff
Using Webrev
Link to Webrev Comment