-
Notifications
You must be signed in to change notification settings - Fork 253
8245545: Disable TLS_RSA cipher suites #3124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back TheMangovnik! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout backport/JDK-8245545
git fetch https://git.openjdk.org/jdk11u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
…abledAlgorithms.java
gnu-andrew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this looks ok. I see three instances with changes that shouldn't be there:
test/jdk/javax/net/ssl/SSLEngine/Basics.javaacquires some refactoring from JDK-8298867. This should just add the lines, as in other tests in 8245545, to re-enable TLS_RSA_* i.e.
+ // Re-enable TLSv1.1 and TLS_RSA_* since test depends on it.
+ SecurityUtils.removeFromDisabledTlsAlgs("TLS_RSA_*");
-
test/jdk/javax/net/ssl/ciphersuites/DisabledAlgorithms.javabrings in a whole bunch of indentation changes from JDK-8301379. It should just add the additional algorithms as in 8245545. -
test/jdk/sun/security/pkcs11/fips/TestTLS12.javaalters the existing Red Hat copyright line for no apparent reason.
JDK-8298867 & JDK-8301379 are both test changes that are in Oracle's 11u and could be backported fully. Given we enter rampdown at the end of this week though, I would like to get this change in and those test changes can be done later if desired. We shouldn't be including chunks of them in this backport though.
Backport of JDK-8245545 - Disable TLS_RSA cipher suites
Some TLS suites do not preserve forward-secrecy and are not commonly used - and should not be used.
Not clean back port. This includes:
Tested on Fedora 43:
Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3124/head:pull/3124$ git checkout pull/3124Update a local copy of the PR:
$ git checkout pull/3124$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3124/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3124View PR using the GUI difftool:
$ git pr show -t 3124Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3124.diff
Using Webrev
Link to Webrev Comment