8352800: [PPC] OpenJDK fails to build on PPC after JDK-8350106

[reinrich]

Hi all,

This pull request contains a backport of commit 72bcd824 from the openjdk/jdk21u-dev repository.

#3957 depends on this backport.
It fixes build problems by including the declaration of class os::Linux referenced in #3957 .
In jdk17 os_linux.hpp cannot be included directly though. os.hpp needs to be included which includes os_linux.hpp into the declaration of class os (see here).

Risk is low.

Thanks, Richard.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8352800 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352800: [PPC] OpenJDK fails to build on PPC after JDK-8350106 (Bug - P4 - Approved)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3949/head:pull/3949
$ git checkout pull/3949

Update a local copy of the PR:
$ git checkout pull/3949
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3949/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3949

View PR using the GUI difftool:
$ git pr show -t 3949

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3949.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352800: [PPC] OpenJDK fails to build on PPC after JDK-8350106

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

• c9fb6f5: 8354701: Open source few JToolTip tests
• 5c4b47c: Merge
• ba6bbe5: 8368308: ISO 4217 Amendment 180 Update
• ... and 44 more: https://git.openjdk.org/jdk17u-dev/compare/ec6528e9cf66abe34b9c293359ca11a4b550b7a8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (5fa5e825)

[TheRealMDoerr]

LGTM.

[openjdk]

⚠️ @reinrich This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[reinrich]

/integrate

[openjdk]

Going to push as commit 1d96b82.
Since your change was applied there have been 52 commits pushed to the master branch:

• dac1fa0: 8363720: Follow up to JDK-8360411 with post review comments
• c80edc3: 8365919: Replace currentTimeMillis with nanoTime in Stresser.java
• 6f50c6d: 8339386: Assertion on AIX - original PC must be in the main code section of the compiled method
• ... and 49 more: https://git.openjdk.org/jdk17u-dev/compare/ec6528e9cf66abe34b9c293359ca11a4b550b7a8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@reinrich Pushed as commit 1d96b82.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.