Skip to content

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Sep 26, 2025

Hi all,

This pull request contains a backport of commit e1071797 from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 16 Sep 2025 and was reviewed by Phil Race.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8367017 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8367017: Remove legacy checks from WrappedToolkitTest and convert from bash (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3995/head:pull/3995
$ git checkout pull/3995

Update a local copy of the PR:
$ git checkout pull/3995
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3995/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3995

View PR using the GUI difftool:
$ git pr show -t 3995

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3995.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 26, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 26, 2025

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367017: Remove legacy checks from WrappedToolkitTest and convert from bash

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport e1071797a4f0ab1a6af29824a777a7800d729b0e 8367017: Remove legacy checks from WrappedToolkitTest and convert from bash Sep 26, 2025
@openjdk
Copy link

openjdk bot commented Sep 26, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 26, 2025
@mrserb mrserb marked this pull request as ready for review September 30, 2025 18:23
@openjdk
Copy link

openjdk bot commented Sep 30, 2025

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 30, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 30, 2025

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Sep 30, 2025

/approval request
Clean backport(The patch is applicable to JDK 17+). Test cleanup: the bash script has been removed.

@openjdk
Copy link

openjdk bot commented Sep 30, 2025

@mrserb
8367017: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Sep 30, 2025
@GoeLin
Copy link
Member

GoeLin commented Oct 2, 2025

Have you verified that the test still works?

@mrserb
Copy link
Member Author

mrserb commented Oct 2, 2025

Have you verified that the test still works?

sure, it works

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants