8339386: Assertion on AIX - original PC must be in the main code section of the compiled method

[TheRealMDoerr]

Backport of JDK-8339386. Applies almost cleanly, but needs a modification (see 2nd commit). orig_pc_offset() is not available in 17u. We can use the frame constructor which doesn't have the problematic assertion in 17u (see comment in the new code).
So, this backport doesn't fix the assertion mentioned in the title (because it doesn't exist in 17u). But, it makes checks more reliable.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8339386 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8339386: Assertion on AIX - original PC must be in the main code section of the compiled method (Bug - P4 - Approved)

Reviewers

• Richard Reingruber (@reinrich - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3998/head:pull/3998
$ git checkout pull/3998

Update a local copy of the PR:
$ git checkout pull/3998
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3998/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3998

View PR using the GUI difftool:
$ git pr show -t 3998

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3998.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339386: Assertion on AIX - original PC must be in the main code section of the compiled method

Reviewed-by: rrich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• c9fb6f5: 8354701: Open source few JToolTip tests
• 5c4b47c: Merge
• ba6bbe5: 8368308: ISO 4217 Amendment 180 Update
• ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/6531254889290c650685346bd8e66f5a2f2ea3e4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (6e4d7e8d)

[reinrich]

I do think the main issue here is using the wrong unextended_sp for a compiled sender if the current frame is interpreted. Then we would load an invalid original pc from the wrong slot.
This issue is solved with the backport. Thanks for doing it!

[openjdk]

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[TheRealMDoerr]

I agree. Thanks for the review!

[TheRealMDoerr]

/approval request This backport makes frame::safe_for_sender more reliable on PPC64. The change only touches this function which is only used for profiling. The change has already been backported to 21.0.6 and there are no known issues. The 17u backport applies almost cleanly, but requires a modification which has been reviewed. The JFR tests have passed.

[openjdk]

@TheRealMDoerr
8339386: The approval request has been created successfully.

[TheRealMDoerr]

/integrate

[openjdk]

Going to push as commit 6f50c6d.
Since your change was applied there have been 8 commits pushed to the master branch:

• 6c4a327: 8353958: Open source several AWT ScrollPane tests - Batch 2
• 0a31d7a: 8328247: Remove redundant dir for tests converted from applet to main
• c9fb6f5: 8354701: Open source few JToolTip tests
• ... and 5 more: https://git.openjdk.org/jdk17u-dev/compare/6531254889290c650685346bd8e66f5a2f2ea3e4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit 6f50c6d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.