Skip to content

Conversation

satyenme
Copy link

@satyenme satyenme commented Sep 29, 2025

Backporting JDK-8355333: Some Problem list entries point to non-existent / wrong files. Renames three existing tests in exclude lists (After JDK-8353958 and JDK-8328247) and removes two tests (that only run on windows). Backporting for parity with Oracle.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8355333 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8355333: Some Problem list entries point to non-existent / wrong files (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4002/head:pull/4002
$ git checkout pull/4002

Update a local copy of the PR:
$ git checkout pull/4002
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4002/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4002

View PR using the GUI difftool:
$ git pr show -t 4002

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4002.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 29, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 32a597b36f994d6e720e0576ad110dac4a5304fe 8355333: Some Problem list entries point to non-existent / wrong files Sep 29, 2025
@openjdk
Copy link

openjdk bot commented Sep 29, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Sep 29, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 29, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 2, 2025

@satyenme Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the clean Identical backport; no merge resolution required label Oct 2, 2025
@openjdk
Copy link

openjdk bot commented Oct 2, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@satyenme
Copy link
Author

satyenme commented Oct 2, 2025

/approval request for backport of JDK-8355333: Some Problem list entries point to non-existent / wrong files

Motivation: With this change, we clean up the test exclusion list and ensure tests that need to be excluded (that have been moved/renamed) are correctly excluded.

Risk: Low. Ran GHA Sanity Checks and adjusted manual tests. Patch is clean. Change has been accepted by Oracle.

@openjdk
Copy link

openjdk bot commented Oct 2, 2025

@satyenme
8355333: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant