-
Notifications
You must be signed in to change notification settings - Fork 232
8355333: Some Problem list entries point to non-existent / wrong files #4002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
6a5fada
to
9ac6027
Compare
@satyenme Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
/approval request for backport of JDK-8355333: Some Problem list entries point to non-existent / wrong files Motivation: With this change, we clean up the test exclusion list and ensure tests that need to be excluded (that have been moved/renamed) are correctly excluded. Risk: Low. Ran GHA Sanity Checks and adjusted manual tests. Patch is clean. Change has been accepted by Oracle. |
Backporting JDK-8355333: Some Problem list entries point to non-existent / wrong files. Renames three existing tests in exclude lists (After JDK-8353958 and JDK-8328247) and removes two tests (that only run on windows). Backporting for parity with Oracle.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4002/head:pull/4002
$ git checkout pull/4002
Update a local copy of the PR:
$ git checkout pull/4002
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4002/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4002
View PR using the GUI difftool:
$ git pr show -t 4002
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4002.diff
Using Webrev
Link to Webrev Comment