-
Notifications
You must be signed in to change notification settings - Fork 232
8360288: Shenandoah crash at size_given_klass in op_degenerated #4003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Reviewed-by: shade
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With respect to 25u backport, looks to be small context diff in shenandoahHeap.hpp, otherwise clean.
|
/approval request This change fixes a crash when Shenandoah unloads the class for an unmarked humongous object. The change only affects Shenandoah. We've tested this with jtreg tiers 1-3 with Shenandoah enabled. We have also tested this on various benchmarks: dacapo, specjvm, specjbb, extremem and others. |
@earthling-amzn |
Not clean.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4003/head:pull/4003
$ git checkout pull/4003
Update a local copy of the PR:
$ git checkout pull/4003
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4003/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4003
View PR using the GUI difftool:
$ git pr show -t 4003
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4003.diff
Using Webrev
Link to Webrev Comment