Skip to content

Conversation

earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented Sep 29, 2025

Not clean.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8360288 needs maintainer approval

Issue

  • JDK-8360288: Shenandoah crash at size_given_klass in op_degenerated (Bug - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4003/head:pull/4003
$ git checkout pull/4003

Update a local copy of the PR:
$ git checkout pull/4003
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4003/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4003

View PR using the GUI difftool:
$ git pr show -t 4003

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4003.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2025

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 29, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 3b44d7bfa4d78e3ec715fce1863e052852f33180 8360288: Shenandoah crash at size_given_klass in op_degenerated Sep 29, 2025
@openjdk
Copy link

openjdk bot commented Sep 29, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Sep 29, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 29, 2025

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With respect to 25u backport, looks to be small context diff in shenandoahHeap.hpp, otherwise clean.

@openjdk
Copy link

openjdk bot commented Sep 30, 2025

⚠️ @earthling-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@earthling-amzn
Copy link
Contributor Author

/approval request This change fixes a crash when Shenandoah unloads the class for an unmarked humongous object. The change only affects Shenandoah. We've tested this with jtreg tiers 1-3 with Shenandoah enabled. We have also tested this on various benchmarks: dacapo, specjvm, specjbb, extremem and others.

@openjdk
Copy link

openjdk bot commented Oct 1, 2025

@earthling-amzn
8360288: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants