-
Notifications
You must be signed in to change notification settings - Fork 233
8363720: Follow up to JDK-8360411 with post review comments #4004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back rgithubli! A progress list of the required criteria for merging this PR into |
@rgithubli This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request A clean backport for JDK-8363720. The updated test passed locally. The prerequisite JDK-8360411 is already in 17. Backporting it for parity with oracle. |
@rgithubli |
/integrate |
@rgithubli |
/sponsor |
Going to push as commit dac1fa0.
Your commit was automatically rebased without conflicts. |
@phohensee @rgithubli Pushed as commit dac1fa0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
A clean backport for JDK-8363720.
The prerequisite JDK-8360411 is already in 17. The updated test passed locally. Backporting it for parity with oracle.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4004/head:pull/4004
$ git checkout pull/4004
Update a local copy of the PR:
$ git checkout pull/4004
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4004/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4004
View PR using the GUI difftool:
$ git pr show -t 4004
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4004.diff
Using Webrev
Link to Webrev Comment