Skip to content

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Sep 30, 2025

Hi all,

This pull request contains a backport of commit 89af6e13 from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 30 Sep 2025 and was reviewed by Alexey Ushakov and Phil Race.

Thanks!


Progress

  • JDK-8362204 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8362204: test/jdk/sun/awt/font/TestDevTransform.java fails on Ubuntu 24.04 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4007/head:pull/4007
$ git checkout pull/4007

Update a local copy of the PR:
$ git checkout pull/4007
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4007/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4007

View PR using the GUI difftool:
$ git pr show -t 4007

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4007.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 30, 2025

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362204: test/jdk/sun/awt/font/TestDevTransform.java fails on Ubuntu 24.04

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 89af6e13f2354d6e32872791d157144cd478a88f 8362204: test/jdk/sun/awt/font/TestDevTransform.java fails on Ubuntu 24.04 Sep 30, 2025
@openjdk
Copy link

openjdk bot commented Sep 30, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 30, 2025
@mrserb mrserb marked this pull request as ready for review October 1, 2025 01:18
@openjdk
Copy link

openjdk bot commented Oct 1, 2025

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 1, 2025
@mrserb
Copy link
Member Author

mrserb commented Oct 1, 2025

/approval request
Clean backport. Fixes test bug. Test failed before the patch and passed after.

@openjdk
Copy link

openjdk bot commented Oct 1, 2025

@mrserb
8362204: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 1, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 1, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 2, 2025
@mrserb
Copy link
Member Author

mrserb commented Oct 4, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 4, 2025

Going to push as commit 94a79aa.
Since your change was applied there have been 12 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 4, 2025
@openjdk openjdk bot closed this Oct 4, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 4, 2025
@openjdk
Copy link

openjdk bot commented Oct 4, 2025

@mrserb Pushed as commit 94a79aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant