Skip to content

8345598: Upgrade NSS binaries for interop tests #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rgangadhar
Copy link
Member

@rgangadhar rgangadhar commented Mar 19, 2025


Progress

  • JDK-8345598 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345598: Upgrade NSS binaries for interop tests (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/146/head:pull/146
$ git checkout pull/146

Update a local copy of the PR:
$ git checkout pull/146
$ git pull https://git.openjdk.org/jdk24u.git pull/146/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 146

View PR using the GUI difftool:
$ git pr show -t 146

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/146.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 19, 2025

👋 Welcome back rgangadhar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 19, 2025

@rgangadhar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345598: Upgrade NSS binaries for interop tests

Reviewed-by: rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 9d41ba1: 8348261: assert(n->is_Mem()) failed: memory node required
  • 77d8da6: 8347995: Race condition in jdk/java/net/httpclient/offline/FixedResponseHttpClient.java
  • 96da000: 8347286: (fs) Remove some extensions from java/nio/file/Files/probeContentType/Basic.java
  • 36765ad: 8351500: G1: NUMA migrations cause crashes in region allocation
  • 3296da8: 8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout
  • f20051f: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rhalade) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 0f82268134df65bbc65ecda158d25f708f18d150 8345598: Upgrade NSS binaries for interop tests Mar 19, 2025
@openjdk
Copy link

openjdk bot commented Mar 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 19, 2025

⚠️ @rgangadhar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 19, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 19, 2025

Webrevs

@openjdk openjdk bot added the approval label Mar 19, 2025
@rgangadhar
Copy link
Member Author

/approval JDK-8345598 "Upgrading NSS Libraries to 3.107"

@openjdk
Copy link

openjdk bot commented Mar 19, 2025

@rgangadhar usage: /approval [<id>] (request|cancel) [<text>]

@rgangadhar
Copy link
Member Author

rgangadhar commented Mar 19, 2025

/approval JDK-8345598 request "Upgrading NSS Libraries to 3.107, test only change no risk"

@openjdk
Copy link

openjdk bot commented Mar 19, 2025

@rgangadhar
JDK-8345598: The approval request has been created successfully.

@rgangadhar
Copy link
Member Author

@rhalade : pls review this changeset

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 21, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 16, 2025

@rgangadhar This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants