Skip to content

8351593: [JMH] test PhoneCode.Bulk reports NPE exception #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Mar 28, 2025

Hi all,

This pull request contains a backport of commit 50ac24eb from the openjdk/jdk repository.

The commit being backported was authored by Vladimir Ivanov on 27 Mar 2025 and was reviewed by Claes Redestad and Derek White.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8351593 needs maintainer approval

Issue

  • JDK-8351593: [JMH] test PhoneCode.Bulk reports NPE exception (Enhancement - P5 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/162/head:pull/162
$ git checkout pull/162

Update a local copy of the PR:
$ git checkout pull/162
$ git pull https://git.openjdk.org/jdk24u.git pull/162/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 162

View PR using the GUI difftool:
$ git pr show -t 162

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/162.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 28, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 50ac24eb0ff06d9b4fc52a6cafea63eb4d59cb95 8351593: [JMH] test PhoneCode.Bulk reports NPE exception Mar 28, 2025
@openjdk
Copy link

openjdk bot commented Mar 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 28, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 28, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 28, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/approval request Clean backport to remove outdated JMH tests, test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Apr 27, 2025

@sendaoYan
8351593: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant