Skip to content
This repository was archived by the owner on Jul 15, 2025. It is now read-only.

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Mar 28, 2025

Hi all,

This pull request contains clean backports of commit 0935ba9a and commit 3319dcfb from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 26 Mar 2025 and was reviewed by Magnus Ihse Bursie and Erik Joelsson.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8352481 needs maintainer approval
  • JDK-8353005 needs maintainer approval

Issues

  • JDK-8352481: Enforce the use of lld with clang (Bug - P4)
  • JDK-8353005: AIX build broken after 8352481 (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/163/head:pull/163
$ git checkout pull/163

Update a local copy of the PR:
$ git checkout pull/163
$ git pull https://git.openjdk.org/jdk24u.git pull/163/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 163

View PR using the GUI difftool:
$ git pr show -t 163

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/163.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 28, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 0935ba9a8c808d372b387d0d0f479f854c121ec1 8352481: Enforce the use of lld with clang Mar 28, 2025
@openjdk
Copy link

openjdk bot commented Mar 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 28, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 28, 2025

Webrevs

@sendaoYan
Copy link
Member Author

/issue add JDK-8353005

@openjdk
Copy link

openjdk bot commented Mar 28, 2025

@sendaoYan
Adding additional issue to issue list: 8353005: AIX build broken after 8352481.

@sendaoYan
Copy link
Member Author

/label add clean

@openjdk
Copy link

openjdk bot commented Mar 28, 2025

@sendaoYan
The label clean is not a valid label.
These labels are valid:

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

Hi, can anyone take look this backport PR. The two backports all are cleans. This backport is intend to fix a little bug in makefile, risk is low.

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label May 13, 2025
@openjdk openjdk bot removed the rfr Pull request is ready for review label May 13, 2025
@phohensee
Copy link
Member

24.0.2 is closed, and it's unlikely there will be a 24.0.3, so I'd withdraw this PR.

@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Jun 4, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 4, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 11, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

24.0.2 is closed, and it's unlikely there will be a 24.0.3, so I'd withdraw this PR.

Okey, Thanks. I think we can close this PR.

@sendaoYan sendaoYan closed this Jun 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants