Skip to content
This repository was archived by the owner on Jul 15, 2025. It is now read-only.

8352879: TestPeriod.java and TestGetContentType.java run wrong test class #169

Closed
wants to merge 2 commits into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Apr 1, 2025

Hi all,

This pull request contains a backport of commit b7ca76ef from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 1 Apr 2025 and was reviewed by Erik Gahlin.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8353235 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8352879 needs maintainer approval

Issues

  • JDK-8352879: TestPeriod.java and TestGetContentType.java run wrong test class (Bug - P4)
  • JDK-8353235: Test jdk/jfr/api/metadata/annotations/TestPeriod.java fails with IllegalArgumentException (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/169/head:pull/169
$ git checkout pull/169

Update a local copy of the PR:
$ git checkout pull/169
$ git pull https://git.openjdk.org/jdk24u.git pull/169/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 169

View PR using the GUI difftool:
$ git pr show -t 169

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/169.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 1, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport b9d7a75adee8a96cf47bbe73e3009102ceda9589 8352879: TestPeriod.java and TestGetContentType.java run wrong test class Apr 1, 2025
@openjdk
Copy link

openjdk bot commented Apr 1, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 1, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 1, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 1, 2025

Webrevs

@openjdk openjdk bot removed the clean label Apr 1, 2025
@sendaoYan
Copy link
Member Author

/issue JDK-8353235

@openjdk
Copy link

openjdk bot commented Apr 1, 2025

@sendaoYan
Adding additional issue to issue list: 8353235: Test jdk/jfr/api/metadata/annotations/TestPeriod.java fails with IllegalArgumentException.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 29, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

wait

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label May 13, 2025
@openjdk openjdk bot removed the rfr Pull request is ready for review label May 13, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented May 27, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/touch

@openjdk
Copy link

openjdk bot commented May 27, 2025

@sendaoYan The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Jun 4, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 4, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

I think jdk24u is not needed backport anymore

@sendaoYan sendaoYan closed this Jun 25, 2025
@sendaoYan sendaoYan deleted the jbs8352879 branch June 25, 2025 02:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants