Skip to content

8304674: File java.c compile error with -fsanitize=address -O0 #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Apr 2, 2025

Hi all,

This pull request contains a backport of commit 9076673d from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 2 Apr 2025 and was reviewed by Magnus Ihse Bursie and Julian Waters.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8304674 needs maintainer approval

Issue

  • JDK-8304674: File java.c compile error with -fsanitize=address -O0 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/173/head:pull/173
$ git checkout pull/173

Update a local copy of the PR:
$ git checkout pull/173
$ git pull https://git.openjdk.org/jdk24u.git pull/173/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 173

View PR using the GUI difftool:
$ git pr show -t 173

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/173.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 2, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 2, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 9076673d7df3c20bdb6e7fdf253030bc19a3d9dc 8304674: File java.c compile error with -fsanitize=address -O0 Apr 2, 2025
@openjdk
Copy link

openjdk bot commented Apr 2, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 2, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 2, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 2, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 30, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant