Skip to content

8353713: Improve Currency.getInstance exception handling #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kieran-farrell
Copy link
Contributor

@kieran-farrell kieran-farrell commented Apr 7, 2025

Exception handling in currency.java improved to include currency code or locale in error message.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8353713 needs maintainer approval

Issue

  • JDK-8353713: Improve Currency.getInstance exception handling (Enhancement - P4) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/182/head:pull/182
$ git checkout pull/182

Update a local copy of the PR:
$ git checkout pull/182
$ git pull https://git.openjdk.org/jdk24u.git pull/182/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 182

View PR using the GUI difftool:
$ git pr show -t 182

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/182.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 7, 2025

👋 Welcome back kieran-farrell! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 7, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 7, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 7, 2025

Webrevs

@kieran-farrell kieran-farrell marked this pull request as draft April 7, 2025 09:13
@openjdk openjdk bot removed the rfr Pull request is ready for review label Apr 7, 2025
@kieran-farrell
Copy link
Contributor Author

Fix already provided by another engineer as documented in JDK-8353713, closing this SR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant