Skip to content

8353545: Improve debug info for StartOptionTest #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Apr 15, 2025

Hi all,

This pull request contains a backport of commit 23eb648c from the openjdk/jdk repository.

The commit being backported was authored by Jan Lahoda on 2 Apr 2025 and was reviewed by Adam Sotona.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8353545 needs maintainer approval

Issue

  • JDK-8353545: Improve debug info for StartOptionTest (Task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/191/head:pull/191
$ git checkout pull/191

Update a local copy of the PR:
$ git checkout pull/191
$ git pull https://git.openjdk.org/jdk24u.git pull/191/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 191

View PR using the GUI difftool:
$ git pr show -t 191

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/191.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 15, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 15, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 23eb648cae1ccadbca0fd654d4fbc28a1b8375e2 8353545: Improve debug info for StartOptionTest Apr 15, 2025
@openjdk
Copy link

openjdk bot commented Apr 15, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 15, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 15, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 15, 2025

Webrevs

@sendaoYan
Copy link
Member Author

sendaoYan commented Apr 15, 2025

Clean backport to enhanced with more test debug information,and this is prefixed backport PR of JDK-8353332. Change has been verified locally, test-fix only, no risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant