Skip to content

8352866: TestLogJIT.java runs wrong test class #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aarti-bijlani
Copy link

@aarti-bijlani aarti-bijlani commented Apr 16, 2025

Clean backport. TestLogJIT should run correct class
Tested in mach5 in all platforms.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8352866 needs maintainer approval
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Issue

  • JDK-8352866: TestLogJIT.java runs wrong test class (Bug - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/198/head:pull/198
$ git checkout pull/198

Update a local copy of the PR:
$ git checkout pull/198
$ git pull https://git.openjdk.org/jdk24u.git pull/198/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 198

View PR using the GUI difftool:
$ git pr show -t 198

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/198.diff

Reviewed-by: rcastanedalo, chagedorn
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Apr 16, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 16, 2025

Hi @aarti-bijlani, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user aarti-bijlani" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Apr 16, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 67c4405250f93a1188c03bf336db160f77a10c7f 8352866: TestLogJIT.java runs wrong test class Apr 16, 2025
@openjdk
Copy link

openjdk bot commented Apr 16, 2025

This backport pull request has now been updated with issue from the original commit.

@aarti-bijlani
Copy link
Author

aarti-bijlani commented Apr 16, 2025

/approval 8352866 request. TestLogJIT should run correct class.

@openjdk
Copy link

openjdk bot commented Apr 16, 2025

@aarti-bijlani
8352866: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 16, 2025
@aarti-bijlani
Copy link
Author

/signed

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Apr 17, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 17, 2025

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@openjdk openjdk bot removed the approval label Apr 17, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2025

@aarti-bijlani This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

2 participants