-
Notifications
You must be signed in to change notification settings - Fork 61
8349705: java.net.URI.scanIPv4Address throws unnecessary URISyntaxException #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8349705: java.net.URI.scanIPv4Address throws unnecessary URISyntaxException #203
Conversation
👋 Welcome back xpeng! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Backport the fix for java.net.URI.scanIPv4Address to avoid unnecessary URISyntaxException; cleanly applied, I have run all the tests under jdk/java/net, overall risk is low. |
@pengxiaolong |
@pengxiaolong This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
Hi all,
This pull request contains a clean backport of commit a90f323d from the openjdk/jdk repository.
The commit being backported was authored by Xiaolong Peng on 8 Mar 2025 and was reviewed by Daniel Fuchs.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/203/head:pull/203
$ git checkout pull/203
Update a local copy of the PR:
$ git checkout pull/203
$ git pull https://git.openjdk.org/jdk24u.git pull/203/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 203
View PR using the GUI difftool:
$ git pr show -t 203
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/203.diff
Using Webrev
Link to Webrev Comment