Skip to content

8349705: java.net.URI.scanIPv4Address throws unnecessary URISyntaxException #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pengxiaolong
Copy link

@pengxiaolong pengxiaolong commented Apr 21, 2025

Hi all,

This pull request contains a clean backport of commit a90f323d from the openjdk/jdk repository.

The commit being backported was authored by Xiaolong Peng on 8 Mar 2025 and was reviewed by Daniel Fuchs.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8349705 needs maintainer approval

Issue

  • JDK-8349705: java.net.URI.scanIPv4Address throws unnecessary URISyntaxException (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/203/head:pull/203
$ git checkout pull/203

Update a local copy of the PR:
$ git checkout pull/203
$ git pull https://git.openjdk.org/jdk24u.git pull/203/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 203

View PR using the GUI difftool:
$ git pr show -t 203

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/203.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 21, 2025

👋 Welcome back xpeng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport a90f323d05f1c90767823b8729b124de0bead265 8349705: java.net.URI.scanIPv4Address throws unnecessary URISyntaxException Apr 21, 2025
@openjdk
Copy link

openjdk bot commented Apr 21, 2025

This backport pull request has now been updated with issue from the original commit.

@pengxiaolong pengxiaolong marked this pull request as ready for review April 21, 2025 16:32
@openjdk
Copy link

openjdk bot commented Apr 21, 2025

⚠️ @pengxiaolong This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 21, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 21, 2025

Webrevs

@pengxiaolong
Copy link
Author

pengxiaolong commented Apr 23, 2025

/approval request Backport the fix for java.net.URI.scanIPv4Address to avoid unnecessary URISyntaxException; cleanly applied, I have run all the tests under jdk/java/net, overall risk is low.

@openjdk
Copy link

openjdk bot commented Apr 23, 2025

@pengxiaolong
8349705: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels Apr 23, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented May 22, 2025

@pengxiaolong This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant