Skip to content

8354541: Remove Shenandoah post barrier expand loop opts #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JohnTortugo
Copy link
Contributor

@JohnTortugo JohnTortugo commented Apr 21, 2025

Hi all,

This pull request contains a backport of commit 4eae9b5b from the openjdk/jdk repository.

The commit being backported was authored by Cesar Soares Lucas on 17 Apr 2025 and was reviewed by Aleksey Shipilev.

Thanks!


Progress

  • JDK-8354541 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8354541: Remove Shenandoah post barrier expand loop opts (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/204/head:pull/204
$ git checkout pull/204

Update a local copy of the PR:
$ git checkout pull/204
$ git pull https://git.openjdk.org/jdk24u.git pull/204/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 204

View PR using the GUI difftool:
$ git pr show -t 204

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/204.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 21, 2025

👋 Welcome back cslucas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 4eae9b5ba61bfe262b43346a7499c98c1a54d2fe 8354541: Remove Shenandoah post barrier expand loop opts Apr 21, 2025
@openjdk
Copy link

openjdk bot commented Apr 21, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 21, 2025

⚠️ @JohnTortugo This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 21, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 21, 2025

Webrevs

@JohnTortugo
Copy link
Contributor Author

/approval Remove post-barrier-expand loop optimizations in Shenandoah. These optimizations have been a burden to maintain. They are frequent source of bugs and they don't contribute much to performance after Shenandoah has migrated to LRB. The patch applies cleanly. Ran GHA Sanity Checks, local Tier 1-3 tests, Dacapo, Renaissance and SPEC benchmarks. Risk is low.

@openjdk
Copy link

openjdk bot commented Apr 28, 2025

@JohnTortugo usage: /approval [<id>] (request|cancel) [<text>]

@JohnTortugo
Copy link
Contributor Author

/approval request for backport. Remove post-barrier-expand loop optimizations in Shenandoah. These optimizations have been a burden to maintain. They are frequent source of bugs and they don't contribute much to performance after Shenandoah has migrated to LRB. The patch applies cleanly. Ran GHA Sanity Checks, local Tier 1-3 tests, Dacapo, Renaissance and SPEC benchmarks. Risk is low.

@openjdk
Copy link

openjdk bot commented Apr 28, 2025

@JohnTortugo
8354541: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant