-
Notifications
You must be signed in to change notification settings - Fork 58
8354541: Remove Shenandoah post barrier expand loop opts #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8354541: Remove Shenandoah post barrier expand loop opts #204
Conversation
👋 Welcome back cslucas! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
/approval Remove post-barrier-expand loop optimizations in Shenandoah. These optimizations have been a burden to maintain. They are frequent source of bugs and they don't contribute much to performance after Shenandoah has migrated to LRB. The patch applies cleanly. Ran GHA Sanity Checks, local Tier 1-3 tests, Dacapo, Renaissance and SPEC benchmarks. Risk is low. |
@JohnTortugo usage: |
/approval request for backport. Remove post-barrier-expand loop optimizations in Shenandoah. These optimizations have been a burden to maintain. They are frequent source of bugs and they don't contribute much to performance after Shenandoah has migrated to LRB. The patch applies cleanly. Ran GHA Sanity Checks, local Tier 1-3 tests, Dacapo, Renaissance and SPEC benchmarks. Risk is low. |
@JohnTortugo |
Hi all,
This pull request contains a backport of commit 4eae9b5b from the openjdk/jdk repository.
The commit being backported was authored by Cesar Soares Lucas on 17 Apr 2025 and was reviewed by Aleksey Shipilev.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/204/head:pull/204
$ git checkout pull/204
Update a local copy of the PR:
$ git checkout pull/204
$ git pull https://git.openjdk.org/jdk24u.git pull/204/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 204
View PR using the GUI difftool:
$ git pr show -t 204
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/204.diff
Using Webrev
Link to Webrev Comment