Skip to content

8380993: [REDO] Incorrect Interpretation of POSIX TZ Environment Variable on AIX#607

Closed
sruthyjay wants to merge 1 commit into
openjdk:masterfrom
sruthyjay:aix-posixtimezone-backport-1320720
Closed

8380993: [REDO] Incorrect Interpretation of POSIX TZ Environment Variable on AIX#607
sruthyjay wants to merge 1 commit into
openjdk:masterfrom
sruthyjay:aix-posixtimezone-backport-1320720

Conversation

@sruthyjay

@sruthyjay sruthyjay commented Jun 12, 2026

Copy link
Copy Markdown

This is a Backport PR : openjdk/jdk#31270



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8380993 needs maintainer approval

Issue

  • JDK-8380993: [REDO] Incorrect Interpretation of POSIX TZ Environment Variable on AIX (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/607/head:pull/607
$ git checkout pull/607

Update a local copy of the PR:
$ git checkout pull/607
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/607/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 607

View PR using the GUI difftool:
$ git pr show -t 607

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/607.diff

Using Webrev

Link to Webrev Comment

Signed-off-by: Sruthy Jayan <srutjay1@in.ibm.com>
@bridgekeeper

bridgekeeper Bot commented Jun 12, 2026

Copy link
Copy Markdown

👋 Welcome back sruthyjay! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 12, 2026

Copy link
Copy Markdown

@sruthyjay This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8380993: [REDO] Incorrect Interpretation of POSIX TZ Environment Variable on AIX

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk Bot changed the title Backport 132072077aa4a15db108989e3d17e6d9249d3ba2 8380993: [REDO] Incorrect Interpretation of POSIX TZ Environment Variable on AIX Jun 12, 2026
@openjdk

openjdk Bot commented Jun 12, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 12, 2026
@openjdk

openjdk Bot commented Jun 12, 2026

Copy link
Copy Markdown

⚠️ @sruthyjay This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 12, 2026
@mlbridge

mlbridge Bot commented Jun 12, 2026

Copy link
Copy Markdown

Webrevs

@sruthyjay

Copy link
Copy Markdown
Author

/approval

@openjdk

openjdk Bot commented Jun 12, 2026

Copy link
Copy Markdown

@sruthyjay usage: /approval [<id>] (request|cancel) [<text>]

@sruthyjay

sruthyjay commented Jun 12, 2026

Copy link
Copy Markdown
Author

/approval JDK- 8380993 clean Backport request to restore correct AIX timezone mapping for modern POSIX TZ strings, preventing incorrect GMT fallback while maintaining backward compatibility with low-risk, AIX-only changes and regression test coverage.

@openjdk

openjdk Bot commented Jun 12, 2026

Copy link
Copy Markdown

@sruthyjay usage: /approval [<id>] (request|cancel) [<text>]

@sruthyjay

Copy link
Copy Markdown
Author

/approval JDK-8380993 request clean Backport to restore correct AIX timezone mapping for modern POSIX TZ strings, preventing incorrect GMT fallback while maintaining backward compatibility with low-risk, AIX-only changes and regression test coverage.

@openjdk

openjdk Bot commented Jun 12, 2026

Copy link
Copy Markdown

@sruthyjay
JDK-8380993: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Jun 12, 2026
@GoeLin

GoeLin commented Jun 12, 2026

Copy link
Copy Markdown
Member

Hi @sruthyjay
please backport to 27 first, or 27u.

@jerboaa

jerboaa commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@sruthyjay Please enable GHA for your fork, thanks. See https://github.com/openjdk/jdk25u-dev/pull/607/checks?check_run_id=80972440379

@openjdk openjdk Bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jun 24, 2026
@sruthyjay

sruthyjay commented Jun 24, 2026

Copy link
Copy Markdown
Author

/integrate

@openjdk openjdk Bot added the sponsor Pull request is ready to be sponsored label Jun 24, 2026
@openjdk

openjdk Bot commented Jun 24, 2026

Copy link
Copy Markdown

@sruthyjay
Your change (at version aa5309b) is now ready to be sponsored by a Committer.

@jerboaa

jerboaa commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@sruthyjay Do you have a GHA run of this before I sponsor?

@sruthyjay

Copy link
Copy Markdown
Author

@jerboaa I have triggered one now : https://github.com/sruthyjay/jdk25u-dev/actions/runs/28098615487

Thank you !

@jerboaa

jerboaa commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@jerboaa I have triggered one now : https://github.com/sruthyjay/jdk25u-dev/actions/runs/28098615487

This one doesn't seem to be a run from your branch.

@sruthyjay

sruthyjay commented Jun 24, 2026

Copy link
Copy Markdown
Author

@jerboaa I have triggered one now : https://github.com/sruthyjay/jdk25u-dev/actions/runs/28098615487

This one doesn't seem to be a run from your branch.

Oops ! sorry .. https://github.com/sruthyjay/jdk25u-dev/actions/runs/28099385168 have triggered it for my branch .. I will cancel the master branch run.

@jerboaa

jerboaa commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@jerboaa I have triggered one now : https://github.com/sruthyjay/jdk25u-dev/actions/runs/28098615487

This one doesn't seem to be a run from your branch.

Oops ! sorry .. https://github.com/sruthyjay/jdk25u-dev/actions/runs/28099385168 have triggered it for my branch .. I will cancel the master branch run.

Thanks. This one shows up on this PR now. The windows build failure is known and should go away with a merged master run. I've triggered one here: https://github.com/jerboaa/jdk25u-dev/actions/runs/28099213050

@jerboaa

jerboaa commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

GHA is clean.

/sponsor

@openjdk

openjdk Bot commented Jun 25, 2026

Copy link
Copy Markdown

Going to push as commit 567ecce.
Since your change was applied there have been 23 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Jun 25, 2026
@openjdk openjdk Bot closed this Jun 25, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 25, 2026
@openjdk

openjdk Bot commented Jun 25, 2026

Copy link
Copy Markdown

@jerboaa @sruthyjay Pushed as commit 567ecce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants