Skip to content

8384161: [PPC64] Consolidate code related to calls in nmethods that use trampoline stubs#627

Draft
reinrich wants to merge 1 commit into
openjdk:masterfrom
reinrich:8384161___PPC64__Consolidate_code_related_to_calls_in_nmethods_that_use_trampoline_stubs
Draft

8384161: [PPC64] Consolidate code related to calls in nmethods that use trampoline stubs#627
reinrich wants to merge 1 commit into
openjdk:masterfrom
reinrich:8384161___PPC64__Consolidate_code_related_to_calls_in_nmethods_that_use_trampoline_stubs

Conversation

@reinrich

@reinrich reinrich commented Jun 23, 2026

Copy link
Copy Markdown
Member

This is a backport of a ppc64 code cleanup (original commit openjdk/jdk@94d3aec).
It consolidates code to generate calls in nmethods that require a trampoline stub to reach far targets into MacroAssembler::trampoline_call().

I want to do this to support maintenance of related parts in general.

Risk is moderate. The change reorganizes existing code, test coverage of calls in nmethods is very good and changes are limited to ppc64.

I had to resolve to simple conflicts.

  • c1_LIRAssembler_ppc.hpp: copyright year mismatch
  • ppc.ad: enc_class postalloc_expand_java_dynamic_call_sched: the removed line call->_method_handle_invoke = _method_handle_invoke; was not present in the original commit.

The fix passed our CI testing:
Tier 1-4 of hotspot and jdk. All of langtools and jaxp. Renaissance Suite and SAP specific tests.
Testing was done on the main platforms and also on Linux/PPC64le and AIX.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8384161 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8384161: [PPC64] Consolidate code related to calls in nmethods that use trampoline stubs (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/627/head:pull/627
$ git checkout pull/627

Update a local copy of the PR:
$ git checkout pull/627
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/627/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 627

View PR using the GUI difftool:
$ git pr show -t 627

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/627.diff

…se trampoline stubs

Reviewed-by: mdoerr, dbriemann
@bridgekeeper

bridgekeeper Bot commented Jun 23, 2026

Copy link
Copy Markdown

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 23, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 94d3aecfed043f0e8825922a17ef1d50e6bc86f7 8384161: [PPC64] Consolidate code related to calls in nmethods that use trampoline stubs Jun 23, 2026
@openjdk

openjdk Bot commented Jun 23, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added the backport Port of a pull request already in a different code base label Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base

Development

Successfully merging this pull request may close these issues.

1 participant