-
Notifications
You must be signed in to change notification settings - Fork 112
8359174: tools/jlink/JLink20000Packages.java timed out #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Vicente Romero <[email protected]> Co-authored-by: Eirik Bjørsnøs <[email protected]> Reviewed-by: jpai, liach
|
Hi @antonvoznia, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user antonvoznia" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
@antonvoznia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/keepalive |
|
@antonvoznia The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@antonvoznia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/keepalive |
|
@antonvoznia The pull request is being re-evaluated and the inactivity timeout has been reset. |
Hi,
It a clean backport of JDK-8359174.
Now, the test
JLink20000Packages.javais passing without the timeout error.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/267/head:pull/267$ git checkout pull/267Update a local copy of the PR:
$ git checkout pull/267$ git pull https://git.openjdk.org/jdk25u.git pull/267/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 267View PR using the GUI difftool:
$ git pr show -t 267Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/267.diff
Using Webrev
Link to Webrev Comment