Skip to content

Conversation

@antonvoznia
Copy link

@antonvoznia antonvoznia commented Oct 3, 2025

Hi,

It a clean backport of JDK-8359174.
Now, the test JLink20000Packages.java is passing without the timeout error.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8359174 needs maintainer approval

Issue

  • JDK-8359174: tools/jlink/JLink20000Packages.java timed out (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/267/head:pull/267
$ git checkout pull/267

Update a local copy of the PR:
$ git checkout pull/267
$ git pull https://git.openjdk.org/jdk25u.git pull/267/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 267

View PR using the GUI difftool:
$ git pr show -t 267

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/267.diff

Using Webrev

Link to Webrev Comment

Co-authored-by: Vicente Romero <[email protected]>
Co-authored-by: Eirik Bjørsnøs <[email protected]>
Reviewed-by: jpai, liach
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Oct 3, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2025

Hi @antonvoznia, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user antonvoznia" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Oct 3, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@antonvoznia antonvoznia changed the title Backport: 0d85f076cc32494c1162baea3ea6b0db67136d41 Backport 0d85f076cc32494c1162baea3ea6b0db67136d41 Oct 3, 2025
@openjdk openjdk bot changed the title Backport 0d85f076cc32494c1162baea3ea6b0db67136d41 8359174: tools/jlink/JLink20000Packages.java timed out Oct 3, 2025
@openjdk
Copy link

openjdk bot commented Oct 3, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Oct 3, 2025
@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Oct 27, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 27, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2025

@antonvoznia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@antonvoznia
Copy link
Author

/keepalive

@openjdk
Copy link

openjdk bot commented Nov 1, 2025

@antonvoznia The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 29, 2025

@antonvoznia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@antonvoznia
Copy link
Author

/keepalive

@openjdk
Copy link

openjdk bot commented Nov 29, 2025

@antonvoznia The pull request is being re-evaluated and the inactivity timeout has been reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants