Skip to content

Conversation

@kieran-farrell
Copy link

@kieran-farrell kieran-farrell commented Oct 14, 2025

Clean backport


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8336695 needs maintainer approval

Issue

  • JDK-8336695: Update Commons BCEL to Version 6.10.0 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/307/head:pull/307
$ git checkout pull/307

Update a local copy of the PR:
$ git checkout pull/307
$ git pull https://git.openjdk.org/jdk25u.git pull/307/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 307

View PR using the GUI difftool:
$ git pr show -t 307

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/307.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 14, 2025

👋 Welcome back kfarrell! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 14, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 3790965df3e7cba3b9792b8719d1e2ead046da15 8336695: Update Commons BCEL to Version 6.10.0 Oct 14, 2025
@openjdk
Copy link

openjdk bot commented Oct 14, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 14, 2025
@openjdk
Copy link

openjdk bot commented Oct 14, 2025

⚠️ @kieran-farrell This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 14, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 14, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2025

@kieran-farrell This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@JoeWang-Java
Copy link
Member

Hi Kieran, there's an issue above in the "Integration blocker" section (Failed to retrieve information on issue 8336695), it's blocking the PR.

Copy link
Member

@JoeWang-Java JoeWang-Java left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the issue has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants