Skip to content

Conversation

@antonvoznia
Copy link

@antonvoznia antonvoznia commented Oct 29, 2025

Hi,

It's a clean backport of 2 fixes:

  • The original one JDK-8365579
  • The second JDK-8366195 that improves the first one
    I decided to make a single commit instead of two separate backports, since it makes sense to have both changes together.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8365579 needs maintainer approval

Issue

  • JDK-8365579: ml64.exe is not the right assembler for Windows aarch64 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/349/head:pull/349
$ git checkout pull/349

Update a local copy of the PR:
$ git checkout pull/349
$ git pull https://git.openjdk.org/jdk25u.git pull/349/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 349

View PR using the GUI difftool:
$ git pr show -t 349

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/349.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 29, 2025

👋 Welcome back antonvoznia! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 29, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title backport a62942424858178ce99cd5df0e4d484620b1631d 8365579: ml64.exe is not the right assembler for Windows aarch64 Oct 29, 2025
@openjdk
Copy link

openjdk bot commented Oct 29, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 29, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 29, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 26, 2025

@antonvoznia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@antonvoznia
Copy link
Author

/touch

@openjdk
Copy link

openjdk bot commented Nov 26, 2025

@antonvoznia The pull request is being re-evaluated and the inactivity timeout has been reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants