Skip to content

Conversation

kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Aug 22, 2025

I'd like to backport it for parity with Oracle 8u.
11u patch applies almost cleanly, except for a license update in THIRD_PARTY_README instead of lcms.md.

GHA testing passes without regressions, test failures look unrelated. Additionally tested manually with J2Ddemo.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8348110 needs maintainer approval

Integration blocker

 ⚠️ Dependency #679 must be integrated first

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/680/head:pull/680
$ git checkout pull/680

Update a local copy of the PR:
$ git checkout pull/680
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/680/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 680

View PR using the GUI difftool:
$ git pr show -t 680

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/680.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2025

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into pr/679 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 22, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 398ba91d4d0cfbc737992a8414a7bec13fc10182 8348110: Update LCMS to 2.17 Aug 22, 2025
@openjdk
Copy link

openjdk bot commented Aug 22, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Aug 22, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 22, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant