Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Aug 27, 2025

Hi all,

I found that gc/survivorAlignment/TestPromotionFromSurvivorToTenuredAfterMinorGC.java intermittent fails which has been fixed by jdk13 in JDK-8218049. I think this fixed PR do not suitable to backport from jdk13 to jdk8u. So I want to backport JDK-8186149 to quarantine this fragile test.

Backport not clean because there are many different context between jdk8u and jdk13 for hotspot/test/ProblemList.txt

Only touch the Problemlist, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8186149 needs maintainer approval

Issue

  • JDK-8186149: quarantine gc/survivorAlignment/TestPromotionFromSurvivorToTenuredAfterMinorGC.java (Sub-task - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/683/head:pull/683
$ git checkout pull/683

Update a local copy of the PR:
$ git checkout pull/683
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/683/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 683

View PR using the GUI difftool:
$ git pr show -t 683

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/683.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 27, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 27, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 19ead83208381512fa2c89673b8d992b6106cc1c 8186149: quarantine gc/survivorAlignment/TestPromotionFromSurvivorToTenuredAfterMinorGC.java Aug 27, 2025
@openjdk
Copy link

openjdk bot commented Aug 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Aug 27, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 27, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 24, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk
Copy link

openjdk bot commented Oct 27, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@sendaoYan
Copy link
Member Author

Thanks for the reviews @phohensee

GHA report two jobs jtreg tests fails. I think the fails is unrelated to this backport PR.

/approval request Backport to problemlist intermittent fail tests. Only touch the Problemlist.txt file, no risk.

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@sendaoYan
8186149: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants