Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Oct 16, 2025

Hi all,

This pull request contains a backport of commit b6876649 from the openjdk/jdk repository.

This backport PR try to fix the test bug, test will skip the '/run/user' directory when it throw FileSystemException. This PR add import jdk.test.lib.Platform; and @library /test/lib make this backport uncleanly, other parts are backport cleanly.

Change has been verified locally, test-fix only, no risk.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8277159 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277159: Fix java/nio/file/FileStore/Basic.java test by ignoring /run/user/* mount points (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/705/head:pull/705
$ git checkout pull/705

Update a local copy of the PR:
$ git checkout pull/705
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/705/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 705

View PR using the GUI difftool:
$ git pr show -t 705

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/705.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 16, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport b6876649a82bed508d817ccbde1600d00937e4b2 8277159: Fix java/nio/file/FileStore/Basic.java test by ignoring /run/user/* mount points Oct 16, 2025
@openjdk
Copy link

openjdk bot commented Oct 16, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 16, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 20, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@sendaoYan
Copy link
Member Author

Thanks for the reviews @phohensee

/approval request Backport to make test skip the '/run/user' directory when it throw FileSystemException on linux. Change has been verified locally on linux-x64, test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Oct 21, 2025

@sendaoYan
8277159: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants