Skip to content

Conversation

@david-beaumont
Copy link
Contributor

@david-beaumont david-beaumont commented Nov 18, 2025

Note for review just yet as I want to see about making the tests common.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8372038: [lworld] Update ExplodedImage to use preview mode correctly (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1743/head:pull/1743
$ git checkout pull/1743

Update a local copy of the PR:
$ git checkout pull/1743
$ git pull https://git.openjdk.org/valhalla.git pull/1743/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1743

View PR using the GUI difftool:
$ git pr show -t 1743

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1743.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2025

👋 Welcome back david-beaumont! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant