8371915: [lworld] LayoutKind enum should have helper methods

[fparain]

Add some helper methods to test properties of layouts in a more reliable way.

Tested with Mach5, tier 1 to 3.

Fred

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8371915: [lworld] LayoutKind enum should have helper methods (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1745/head:pull/1745
$ git checkout pull/1745

Update a local copy of the PR:
$ git checkout pull/1745
$ git pull https://git.openjdk.org/valhalla.git pull/1745/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1745

View PR using the GUI difftool:
$ git pr show -t 1745

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1745.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[mlbridge]

Webrevs

• 00: Full (f10829c3)

[DanHeidinga]

Why does NULLABLE_ATOMIC_FLAT produce NON_ATOMIC? Something, maybe just naming?, seems off here.

I know this is a refactoring of existing code and so has the same meaning but it doesn't make sense to me

[fparain]

Good catch!
I've copied/pasted this code when refactoring without verifying it.
It doesn't make sense to me either.
For LayoutKind::NULLABLE_ATOMIC_FLAT the method should return ArrayKlass::ArrayProperties::DEFAULT.
Let me fix this and run some tests.