Skip to content

Synchronize agent configurations - #52

Merged
furykerry merged 5 commits into
openkruise:masterfrom
tianhr:feat/sync-agents
Sep 3, 2026
Merged

furykerry merged 5 commits into
openkruise:masterfrom
tianhr:feat/sync-agents

Conversation

@tianhr

@tianhr tianhr commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@kruise-bot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

# generated by datamodel-codegen:
# filename: poolautoscaler_schema.json
# timestamp: 2026-09-02T10:13:26+00:00

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k8s/python/openkruise/agents/models/init.py:has not export poolautoscaler,Python SDK can not from openkruise.agents.models import PoolAutoscaler。

@furykerry

Copy link
Copy Markdown
Member

The CRD files under agents/crds/*.yaml all carry the header controller-gen.kubebuilder.io/version: v0.18.0, but the Makefile still pins controller-gen at v0.16.5. This mismatch means that anyone running make generate or make gen-schema-only locally will regenerate the CRDs with v0.16.5, causing the committed schema to drift from the local output.

Suggestion: either bump the controller-gen pin in the Makefile to v0.18.0 to match the committed CRDs, or explicitly note in the PR description that the v0.18.0 CRDs are a one-off external artifact and that the Makefile upgrade will follow in a subsequent change.

@furykerry
furykerry merged commit 9f0b46e into openkruise:master Sep 3, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants