Google maps webkit svg bug #1243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 4, 2014 12:00
| @@ -450,6 +450,10 @@ OpenLayers.Renderer.SVG = OpenLayers.Class(OpenLayers.Renderer.Elements, { | |||
| createRenderRoot: function() { | |||
| var svg = this.nodeFactory(this.container.id + "_svgRoot", "svg"); | |||
| svg.style.display = "block"; | |||
|
|
|||
| if (window.google && window.google.maps && window.google.maps.Map) { | |||
| svg.style['-webkit-transform'] = 'translateZ(0)'; | |||
There was a problem hiding this comment.
Actually I liked the pure css solution better.
.olForeignContainer svg {
-webkit-transform: translateZ(0);
}Especially because all GPU acceleration in OpenLayers is set in style.css too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue outlined in openlayers/openlayers#1207.
I've added a manual test that demonstrates the issue as well as a fix. However, I'm not 100% sure the fix is in the right place. The problem is solved by turning on GPU acceleration when Google Maps V3 base layer is present.
I could have put a style declaration in the default theme css but I guess not everyone will include it when using OL. So, I've put some logic in the SVG renderer. It checks for the presence of google.maps.Map and if present, adds the style declaration to turn on GPU acceleration. Part of me thinks it shouldn't be here - the render shouldn't need to know about any external global objects i.e. google, but couldn't think of a better place to put it.