Skip to content

Add a basic test case to compare-and-submit#2

Merged
strader merged 1 commit intoopenlearninginitiative:masterfrom
pmitros:master
Feb 12, 2016
Merged

Add a basic test case to compare-and-submit#2
strader merged 1 commit intoopenlearninginitiative:masterfrom
pmitros:master

Conversation

@pmitros
Copy link
Copy Markdown
Contributor

@pmitros pmitros commented Jan 13, 2016

This adds a basic test case to this XBlock. In order to run the test, use:

paver test_system -t openedx/tests/xblock_integration/test_external_xblocks.py

Note that I have not confirmed whether this works on master. The test framework has several bugs with a PR to fix several bugs in flight (https://github.com/edx/edx-platform/pull/10747), and I'm working off of a branch with those tests fixed.

@strader

@pmitros
Copy link
Copy Markdown
Contributor Author

pmitros commented Jan 13, 2016

@cahrens FYI: This XBlock may come up for code review in the not-too-distant-future. It was built by Ross. I did code review, and a pair of PRs to bring it up to PEP8, and add a basic test case. I'm not sure what else @strader has in mind for it before he thinks its launch-ready, but on a code review, those were the major gaps I saw with regards to edx.org XBlock standards. I'd wait for feedback from Ross, but I just wanted to get it onto your radar.

@strader
Copy link
Copy Markdown
Contributor

strader commented Feb 10, 2016

@pmitros: Thanks for adding this test case. Can you let me know when the test framework is up to date on master? This xblock is already running on the Stanford Open edX instance, so I'd like to wait to merge until we know it's not going to break anything.

@pmitros
Copy link
Copy Markdown
Contributor Author

pmitros commented Feb 10, 2016

Oh. It's been on master for a while.

@strader strader merged commit c9a71f3 into openlearninginitiative:master Feb 12, 2016
@strader
Copy link
Copy Markdown
Contributor

strader commented Feb 13, 2016

@pmitros: Great, thanks Piotr. I've merged the test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants