Fix #117: Linting standards for software-developer-tool #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ash-2k3 <[email protected]>
|
This PR is still WIP: We need to decide on configurations like, max-length allowed, if we want to ignore some specific errors, etc.. |
|
Also, once this PR gets merged, we would want to update the installation.md file to install two more packages which are |
|
I am planning to close this PR for now, as I have thought of a better approach to add linters and also we need to discuss about the coding standards for linting (This can be done in the upcoming meet on 8th May). Thanks! /cc @pleia2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #117.
This PR introduces the usage of flake8 for this project. I chose Flake8 for this project because our current priority is establishing a strong baseline for code style and catching common errors. Flake8 does this efficiently with minimal overhead. It's also easier for the team to adopt and maintain. If the project grows significantly in complexity, we can always consider integrating a more comprehensive linter like Pylint in the future.